Uh oh!
There was an error while loading. Please reload this page.
fix scheduler panic if user puts in wrong schedule - #160
Merged
Conversation
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the cron schedule parser to prevent a panic when a user supplies a timezone prefix (TZ= / CRON_TZ=) without an accompanying schedule, returning a descriptive error instead.
Changes:
- Parse timezone prefixes using
strings.IndexFunc(..., unicode.IsSpace)so any whitespace separator (e.g., tabs) is accepted. - Add an explicit error return when a timezone prefix is not followed by a schedule (avoids slice-out-of-range panic).
- Extend parser tests to cover missing-schedule timezone prefixes and tab-separated timezone schedules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cron/parser.go | Prevents panic on timezone-only specs and broadens whitespace handling for timezone parsing. |
cron/parser_test.go | Adds regression tests for timezone-only specs and verifies tab-separated timezone schedules parse correctly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JoshVanL
approved these changes
Jul 21, 2026
Uh oh!
There was an error while loading. Please reload this page.
JoshVanL pushed a commit
that referenced
this pull request
Jul 29, 2026
* fix scheduler panic if user puts in wrong schedule (#160) * fix scheduler panic if user puts in wrong schedule Signed-off-by: Cassandra Coyle <cassie@diagrid.io> * add test Signed-off-by: Cassandra Coyle <cassie@diagrid.io> --------- Signed-off-by: Cassandra Coyle <cassie@diagrid.io> * handle @every schedule with timezone (#161) * handle @every with timezone, should not happen Signed-off-by: Cassandra Coyle <cassie@diagrid.io> * PR feedback Signed-off-by: Cassandra Coyle <cassie@diagrid.io> --------- Signed-off-by: Cassandra Coyle <cassie@diagrid.io> --------- Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix scheduler panic if user puts in wrong schedule