valkey test container

[daric93]

No description provided.

[jbrinkman]

Deprecated Decorator Usage

Location:modules/valkey/testcontainers/valkey/__init__.py, line 113

Current Code:

@wait_container_is_ready(ValkeyNotReady)def_connect(self) ->None:
"""Wait for Valkey to be ready by sending PING command."""# ... connection logic

Issue:

The @wait_container_is_ready decorator is deprecated in the codebase. Recent commits show active migration away from this pattern:

• PR feat: Add ExecWaitStrategy and migrate Postgres from deprecated decorator testcontainers/testcontainers-python#935: Postgres migrated to ExecWaitStrategy
• PR fix(minio): Use wait strategy instead of deprecated decorator testcontainers/testcontainers-python#899: Minio migrated to wait strategies
• PR fix(elasticsearch): Use wait strategy instead of deprecated decorator testcontainers/testcontainers-python#915: Elasticsearch migrated to wait strategies

Evidence from Codebase:

# From pytest.ini_options filterwarnings:"ignore:The @wait_container_is_ready decorator is deprecated.*:DeprecationWarning"

Recommended Fix:

Migrate to modern wait strategy pattern:

fromtestcontainers.core.wait_strategiesimportExecWaitStrategyclassValkeyContainer(DockerContainer):
def__init__(self, image: str="valkey/valkey:latest", port: int=6379, **kwargs) ->None:
super().__init__(image, **kwargs)
self.port=portself.password: Optional[str] =Noneself.with_exposed_ports(self.port)
defstart(self) ->"ValkeyContainer":
# Build wait strategy based on passwordifself.password:
# Use custom wait strategy for authenticated connectionsself.waiting_for(self._create_auth_wait_strategy())
else:
# Use exec strategy for simple PINGself.waiting_for(
ExecWaitStrategy(["valkey-cli", "ping"])
)
super().start()
returnself

Benefits:

• Aligns with project direction
• More composable and testable
• Consistent with other modules
• Better error messages

[daric93]

fixed