Uh oh!
There was an error while loading. Please reload this page.
qt: General CSS related redesigns - #3563
Merged
Merged
Conversation
This was referenced Jun 26, 2020
xdustinfaceforce-pushed
the
pr-ui-10-css-updates
branch
2 times, most recently
from
June 27, 2020 20:23
5256ad9 to
568d1b9Comparexdustinface
marked this pull request as draft
June 30, 2020 20:19
xdustinfaceforce-pushed
the
pr-ui-10-css-updates
branch
from
July 14, 2020 14:59
568d1b9 to
542b4eeComparexdustinface
marked this pull request as ready for review
July 14, 2020 15:01
xdustinface
commented
Jul 14, 2020
Author
This was referenced Jul 14, 2020
PastaPastaPasta
previously approved these changes
Jul 14, 2020
PastaPastaPasta
left a comment
Member
There was a problem hiding this comment.
utACK, made sure changes only touch css.
One question though
There was a problem hiding this comment.
can you explain the reason for this?
Author
There was a problem hiding this comment.
Just that relevant colors are all in the same #aarrggbb format and that its catched by contrib/devtools/update-css-files.py. There is still the named color red but thats only a placeholder to show an undefined behaviour in the UI. So if there is a bright red somewhere in the UI it means the related color in general.css isn't overwritten in the theme file. I want to write some UI development style guidelines anytime later where i will explain such thoughts i had.
UdjinM6
commented
Jul 14, 2020
Looks very nice in general 👍 traditional theme is a bit weird though and needs few more fixes imo, pls see 6639cb3e6e |
xdustinface
commented
Jul 14, 2020
Author
thanks :) the thing with the traditional is weird.. will push the fix for sure but when i made the walkthrough video i hadn't this bugs in there and now i wonder where on the road i messed with that.. need to investigate here a little first if i messed something else too 🤔 |
xdustinfaceforce-pushed
the
pr-ui-10-css-updates
branch
from
July 14, 2020 23:12
542b4ee to
5a90caeComparexdustinface
commented
Jul 14, 2020
Author
Ok no, all-clear, nothing is lost you just got me confused haha.. its the same like back there i just didn't realise that i had the text color twice in there when looked at your diff earlier and then i thought the tab button texts are red but thats overwritten below and you just removed it 🙈 Picked your commit and updated the colors sections in the css files. |
For some reason image produced weird outputs on some resolution screens.
This includes css files and any color usage in code.
- Give the progress label a name as css reference - Set min height and margins
- Set a light rounded border - Color for disabled items - Color/Style for seperator - Give the items padding
- Add light line below the coincontrol frame - Add light line above fee frame - Increase header font size - Remove button layout changes of CoinControl button - Fix Layout/Alignment of balance labels
This is the datadir selection dialog.
No text colors, s/transparent/#00000000/
xdustinfaceforce-pushed
the
pr-ui-10-css-updates
branch
from
July 14, 2020 23:36
5a90cae to
2cbd642Comparexdustinface added a commit
to xdustinface/dash
that referenced
this pull request
Sep 1, 2020
* qt: User border-image in place of image For some reason image produced weird outputs on some resolution screens. * qt: Fix layout issues in TransactionView * qt: Fix layout issues in OverviewPage * qt: Replace transparent with #00000000 in stylesheets * qt: Use #a84832 as red where possible. This includes css files and any color usage in code. * qt: Finetune QPushButton style * qt: Customized QSlider (used in the Debug window -> NetworkTraffic) * qt: Finetune QToolbar style * qt: Customized QProgressBar * qt: Customized QCalendarWidget * qt: Finetune QStatusBar style - Give the progress label a name as css reference - Set min height and margins * qt: Finetune QMenu style - Set a light rounded border - Color for disabled items - Color/Style for seperator - Give the items padding * qt: Customized QGroupBox * qt: Customized QToolTip * qt: Give inputs widgets a proper hover/focus/selected/disabled style * qt: Finetune SendCoinsDialog - Add light line below the coincontrol frame - Add light line above fee frame - Increase header font size - Remove button layout changes of CoinControl button - Fix Layout/Alignment of balance labels * qt: Customized RPC console's autocompletition popup * qt: Add stylesheets to Intro This is the datadir selection dialog. * qt: OptionsDialog - Give the reset button the "light button" style * qt: Finetune shared styles in general.css * qt: Finetune coloring in dark.css * qt: Finetune coloring in light.css * More fixes for traditional.css No text colors, s/transparent/#00000000/ * qt: Run update-css-files.py Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 3, 2022
* qt: User border-image in place of image For some reason image produced weird outputs on some resolution screens. * qt: Fix layout issues in TransactionView * qt: Fix layout issues in OverviewPage * qt: Replace transparent with #00000000 in stylesheets * qt: Use #a84832 as red where possible. This includes css files and any color usage in code. * qt: Finetune QPushButton style * qt: Customized QSlider (used in the Debug window -> NetworkTraffic) * qt: Finetune QToolbar style * qt: Customized QProgressBar * qt: Customized QCalendarWidget * qt: Finetune QStatusBar style - Give the progress label a name as css reference - Set min height and margins * qt: Finetune QMenu style - Set a light rounded border - Color for disabled items - Color/Style for seperator - Give the items padding * qt: Customized QGroupBox * qt: Customized QToolTip * qt: Give inputs widgets a proper hover/focus/selected/disabled style * qt: Finetune SendCoinsDialog - Add light line below the coincontrol frame - Add light line above fee frame - Increase header font size - Remove button layout changes of CoinControl button - Fix Layout/Alignment of balance labels * qt: Customized RPC console's autocompletition popup * qt: Add stylesheets to Intro This is the datadir selection dialog. * qt: OptionsDialog - Give the reset button the "light button" style * qt: Finetune shared styles in general.css * qt: Finetune coloring in dark.css * qt: Finetune coloring in light.css * More fixes for traditional.css No text colors, s/transparent/#00000000/ * qt: Run update-css-files.py Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ist part of a series of +-25 PRs related to UI redesigns. Its ancestor is #3562, its successor is #3564. I did not screenshot every single PR and its changes, instead i made "walk through all screen" videos with the result of this PR series and also with the 0.15 UI. If there are any concrete screenshots wanted, just let me know. To build with the full set of changes you can build from the branch xdustinface:pr-ui-redesign which always contains all changes.
-> Walk through 0.15
-> Walk through Redesign
I tried to give the commits enough text to make things obvious without a lot description for each PR. Also here, if you want more description for this specific PR, let me know.
About this PR
See individual commit messages.