Skip to content

Qt: Add DMT-like Governance Functionality refs #4337 - - #4358

Closed
daharkan wants to merge 27 commits into
dashpay:developfrom
daharkan:develop
Closed

Qt: Add DMT-like Governance Functionality refs #4337 -#4358
daharkan wants to merge 27 commits into
dashpay:developfrom
daharkan:develop

Conversation

@daharkan

@daharkandaharkan commented Aug 23, 2021

Copy link
Copy Markdown

CGovernanceObject has been modified and added extra setters.

Governance Tab is added just like Masternodes tab and optiondialog is also modified
like masternodes tab option.

@github-actions

github-actionsBot commented Aug 23, 2021

Copy link
Copy Markdown

This pull request has conflicts, please rebase.

@github-actions

github-actionsBot commented Aug 24, 2021

Copy link
Copy Markdown

This pull request has conflicts, please rebase.

UdjinM6
UdjinM6 requested changes Aug 25, 2021
View reviewed changes

@UdjinM6UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not compilable

Comment threadsrc/governance/governance-object.cpp Outdated
@UdjinM6
UdjinM6 marked this pull request as draft August 25, 2021 11:30
@daharkan

daharkan commented Aug 29, 2021

Copy link
Copy Markdown
Author

Not compilable
Fixed

@PastaPastaPasta

PastaPastaPasta commented Aug 30, 2021

Copy link
Copy Markdown
Member

There are still problems with CI fyi

@daharkan
daharkan marked this pull request as ready for review August 30, 2021 22:02
PastaPastaPasta
PastaPastaPasta reviewed Sep 1, 2021
View reviewed changes
Comment threadCMakeLists.txt Outdated

@PastaPastaPastaPastaPastaPastaSep 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to revert all these misc changes

@daharkandaharkanSep 1, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary end-lines etc removed.

daharkan
daharkan commented Sep 1, 2021
View reviewed changes

@daharkandaharkan left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary end-lines etc are reverted. Functional code blocks are keeped

PastaPastaPasta
PastaPastaPasta requested changes Sep 2, 2021
View reviewed changes
Comment threadsrc/governance/governance-object.cpp Outdated
Comment threadsrc/qt/clientmodel.cpp Outdated
Comment threadsrc/qt/governancelist.cpp Outdated
@PastaPastaPasta

PastaPastaPasta commented Sep 2, 2021

Copy link
Copy Markdown
Member

Please rebase on develop, instead of merging develop

@PastaPastaPasta

PastaPastaPasta commented Sep 8, 2021

Copy link
Copy Markdown
Member

Please see the Clang-Format CI and apply those change (all of them may not apply, but the vast majority should).

@github-actions

github-actionsBot commented Sep 9, 2021

Copy link
Copy Markdown

This pull request has conflicts, please rebase.

@daharkan

daharkan commented Sep 10, 2021

Copy link
Copy Markdown
Author

Please see the Clang-Format CI and apply those change (all of them may not apply, but the vast majority should).

I've applied all. But upstream has been changed since last rebase. I rebased and pushed after resolving conftlicts.

@github-actions

github-actionsBot commented Oct 1, 2021

Copy link
Copy Markdown

This pull request has conflicts, please rebase.

@UdjinM6

UdjinM6 commented Oct 29, 2021

Copy link
Copy Markdown

closing in fav of #4351

@UdjinM6UdjinM6 closed this Oct 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6UdjinM6UdjinM6 requested changes
@PastaPastaPastaPastaPastaPastaPastaPastaPasta requested changes

Assignees

No one assigned

Labels

needs rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daharkan@PastaPastaPasta@UdjinM6