Skip to content

llmq: Clean old DKG contributions up - #4763

Merged
UdjinM6 merged 3 commits into
dashpay:developfrom
UdjinM6:cleanup_dkgdb
Apr 19, 2022
Merged

llmq: Clean old DKG contributions up#4763
UdjinM6 merged 3 commits into
dashpay:developfrom
UdjinM6:cleanup_dkgdb

Conversation

@UdjinM6

Copy link
Copy Markdown

No description provided.

@UdjinM6UdjinM6 added this to the 18 milestone Apr 11, 2022
Comment threadsrc/llmq/dkgsessionmgr.cpp Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be done on a new thread? and preferably without locking cs_main (or at least not as much as you are)?

Comment threadsrc/llmq/dkgsessionmgr.cpp Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use this as opposed to c-style casting

Suggested change
LogPrint(BCLog::LLMQ, "CDKGSessionManager::%s -- found %lld entries for llmq type %d\n", __func__, cnt_all, (uint8_t)params.type);
LogPrint(BCLog::LLMQ, "CDKGSessionManager::%s -- found %lld entries for llmq type %d\n", __func__, cnt_all, uint8_t(params.type));

@PastaPastaPasta

Copy link
Copy Markdown
Member

DNM until after #4752 is merged

@github-actions

Copy link
Copy Markdown

This pull request has conflicts, please rebase.

@PastaPastaPastaPastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPastaPastaPastaPasta modified the milestones: 18, 19Apr 18, 2022
@UdjinM6
UdjinM6 merged commit 26d774b into dashpay:developApr 19, 2022
@PastaPastaPasta

Copy link
Copy Markdown
Member

@UdjinM6 is this milestone correct?

@UdjinM6UdjinM6 modified the milestones: 19, 18Apr 19, 2022
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Nov 16, 2023
* llmq: Clean old DKG contributions up
* apply review suggestions and a bit more
* use scheduler
gades pushed a commit to piratecash/pirate that referenced this pull request Dec 9, 2023
* llmq: Clean old DKG contributions up
* apply review suggestions and a bit more
* use scheduler
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@UdjinM6@PastaPastaPasta