Skip to content

build: switch to classical major.minor.patch semver - #4817

Merged
UdjinM6 merged 2 commits into
dashpay:developfrom
UdjinM6:drop_0
Apr 28, 2022
Merged

build: switch to classical major.minor.patch semver#4817
UdjinM6 merged 2 commits into
dashpay:developfrom
UdjinM6:drop_0

Conversation

@UdjinM6

@UdjinM6UdjinM6 commented Apr 28, 2022

Copy link
Copy Markdown

#4768 follow-up

I believe it's better to do it this way cause it makes CLIENT_VERSION comparable again (4768 bumped it +1000000 while normally major versions bump it +10000).

MarcoFalkeand others added 2 commits April 28, 2022 13:47
MarcoFalke@UdjinM6
Mergebitcoin#20223: build: Drop the leading 0 from the version number
a3a7a22
8f7b930 Drop the leading 0 from the version number (Andrew Chow)
Pull request description:
Removes the leading 0 from the version number. The minor version, which we had been using as the major version, is now the major version. The revision, which we had been using as the minor version, is now the minor version. The revision number is dropped. The build number is promoted to being part of the version number. This also avoids issues where it was accidentally not included in the version number.
The CLIENT_VERSION remains the same format as previous as previously, as the Major version was 0 so it never actually got included in it.
The user agent string formatter is updated to follow this new versioning.
***
Honestly I'm just tired of all of the people asking for "1.0" that maybe this'll shut them up. Skip the whole 1.0 thing and go straight to version 22.0!
Also, this means that the terminology we commonly use lines up with how the variables are named. So major versions are actually bumping the major version number, etc.
ACKs for top commit:
jnewbery:
Code review ACK 8f7b930
MarcoFalke:
review ACK 8f7b930 🎻
Tree-SHA512: b5c3fae14d4c0a9c0ab3b1db7c949ecc0ac3537646306b13d98dd0efc17c489cdd16d43f0a24aaa28e9c4a92ea360500e05480a335b03f9fb308010cdd93a436
@laanwj@UdjinM6
Mergebitcoin#20449: build: Fix Windows installer build
a064b4c
68c2ef1 Fix version string in Windows and Mac installers (Andrew Chow)
Pull request description:
Apparently NSIS requires a 4 digit version number, and bitcoin#20223 dropped the 4th digit. So this adds a 4th 0 digit so that building the Windows installer doesn't fail. Also fixes a typo in that version string that was also present in a plist file.
ACKs for top commit:
fanquake:
ACK 68c2ef1
laanwj:
Code review ACK 68c2ef1
hebasto:
Approach ACK 68c2ef1, tested on Linux Mint 20 (x86_64, nsis 3.05-2).
Tree-SHA512: 845560ff176eae8081096426790c928a773fa75d366f42a2a4631c1be2ae9234d7a5b72854ccfaa7fa1a32002b937ca393b12168ffacf9a5e3e311a76725483a
@UdjinM6UdjinM6 added this to the 18 milestone Apr 28, 2022
PastaPastaPasta
PastaPastaPasta approved these changes Apr 28, 2022
View reviewed changes

@PastaPastaPastaPastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@UdjinM6
UdjinM6 merged commit b22d589 into dashpay:developApr 28, 2022
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request May 18, 2022
@UdjinM6@PastaPastaPasta
Merge pull requestdashpay#4817from UdjinM6/drop_0
1d2c9da
build: switch to classical `major.minor.patch` semver
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6@PastaPastaPasta@laanwj
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
build: switch to classical `major.minor.patch` semver by UdjinM6 · Pull Request #4817 · dashpay/dash · GitHub
Skip to content
build: switch to classical major.minor.patch semver - #4817
Merged
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Apr 28, 2022
Merged
build: switch to classical major.minor.patch semver#4817
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Apr 28, 2022

Copy link


Copy Markdown

#4768 follow-up
I believe it's better to do it this way cause it makes CLIENT_VERSION comparable again (4768 bumped it +1000000 while normally major versions bump it +10000).
MarcoFalkeand others
added 2 commits
April 28, 2022 13:47
MarcoFalke@UdjinM6
Mergebitcoin#20223: build: Drop the leading 0 from the version number
a3a7a22
8f7b930 Drop the leading 0 from the version number (Andrew Chow)
Pull request description:
Removes the leading 0 from the version number. The minor version, which we had been using as the major version, is now the major version. The revision, which we had been using as the minor version, is now the minor version. The revision number is dropped. The build number is promoted to being part of the version number. This also avoids issues where it was accidentally not included in the version number.
The CLIENT_VERSION remains the same format as previous as previously, as the Major version was 0 so it never actually got included in it.
The user agent string formatter is updated to follow this new versioning.
***
Honestly I'm just tired of all of the people asking for "1.0" that maybe this'll shut them up. Skip the whole 1.0 thing and go straight to version 22.0!
Also, this means that the terminology we commonly use lines up with how the variables are named. So major versions are actually bumping the major version number, etc.
ACKs for top commit:
jnewbery:
Code review ACK 8f7b930
MarcoFalke:
review ACK 8f7b930 🎻
Tree-SHA512: b5c3fae14d4c0a9c0ab3b1db7c949ecc0ac3537646306b13d98dd0efc17c489cdd16d43f0a24aaa28e9c4a92ea360500e05480a335b03f9fb308010cdd93a436
@laanwj@UdjinM6
Mergebitcoin#20449: build: Fix Windows installer build
a064b4c
68c2ef1 Fix version string in Windows and Mac installers (Andrew Chow)
Pull request description:
Apparently NSIS requires a 4 digit version number, and bitcoin#20223 dropped the 4th digit. So this adds a 4th 0 digit so that building the Windows installer doesn't fail. Also fixes a typo in that version string that was also present in a plist file.
ACKs for top commit:
fanquake:
ACK 68c2ef1
laanwj:
Code review ACK 68c2ef1
hebasto:
Approach ACK 68c2ef1, tested on Linux Mint 20 (x86_64, nsis 3.05-2).
Tree-SHA512: 845560ff176eae8081096426790c928a773fa75d366f42a2a4631c1be2ae9234d7a5b72854ccfaa7fa1a32002b937ca393b12168ffacf9a5e3e311a76725483a
@UdjinM6UdjinM6
added this to the 18 milestone
Apr 28, 2022
PastaPastaPasta
PastaPastaPasta
approved these changes
Apr 28, 2022
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit
@UdjinM6
UdjinM6
merged commit b22d589
into
dashpay:developApr 28, 2022
PastaPastaPasta pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 18, 2022
@UdjinM6@PastaPastaPasta
Merge pull requestdashpay#4817from UdjinM6/drop_0
1d2c9da
build: switch to classical `major.minor.patch` semver
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6@PastaPastaPasta@laanwj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
build: switch to classical `major.minor.patch` semver by UdjinM6 · Pull Request #4817 · dashpay/dash · GitHub
Skip to content
build: switch to classical major.minor.patch semver - #4817
Merged
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Apr 28, 2022
Merged
build: switch to classical major.minor.patch semver#4817
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Apr 28, 2022

Copy link


Copy Markdown

#4768 follow-up
I believe it's better to do it this way cause it makes CLIENT_VERSION comparable again (4768 bumped it +1000000 while normally major versions bump it +10000).
MarcoFalkeand others
added 2 commits
April 28, 2022 13:47
MarcoFalke@UdjinM6
Mergebitcoin#20223: build: Drop the leading 0 from the version number
a3a7a22
8f7b930 Drop the leading 0 from the version number (Andrew Chow)
Pull request description:
Removes the leading 0 from the version number. The minor version, which we had been using as the major version, is now the major version. The revision, which we had been using as the minor version, is now the minor version. The revision number is dropped. The build number is promoted to being part of the version number. This also avoids issues where it was accidentally not included in the version number.
The CLIENT_VERSION remains the same format as previous as previously, as the Major version was 0 so it never actually got included in it.
The user agent string formatter is updated to follow this new versioning.
***
Honestly I'm just tired of all of the people asking for "1.0" that maybe this'll shut them up. Skip the whole 1.0 thing and go straight to version 22.0!
Also, this means that the terminology we commonly use lines up with how the variables are named. So major versions are actually bumping the major version number, etc.
ACKs for top commit:
jnewbery:
Code review ACK 8f7b930
MarcoFalke:
review ACK 8f7b930 🎻
Tree-SHA512: b5c3fae14d4c0a9c0ab3b1db7c949ecc0ac3537646306b13d98dd0efc17c489cdd16d43f0a24aaa28e9c4a92ea360500e05480a335b03f9fb308010cdd93a436
@laanwj@UdjinM6
Mergebitcoin#20449: build: Fix Windows installer build
a064b4c
68c2ef1 Fix version string in Windows and Mac installers (Andrew Chow)
Pull request description:
Apparently NSIS requires a 4 digit version number, and bitcoin#20223 dropped the 4th digit. So this adds a 4th 0 digit so that building the Windows installer doesn't fail. Also fixes a typo in that version string that was also present in a plist file.
ACKs for top commit:
fanquake:
ACK 68c2ef1
laanwj:
Code review ACK 68c2ef1
hebasto:
Approach ACK 68c2ef1, tested on Linux Mint 20 (x86_64, nsis 3.05-2).
Tree-SHA512: 845560ff176eae8081096426790c928a773fa75d366f42a2a4631c1be2ae9234d7a5b72854ccfaa7fa1a32002b937ca393b12168ffacf9a5e3e311a76725483a
@UdjinM6UdjinM6
added this to the 18 milestone
Apr 28, 2022
PastaPastaPasta
PastaPastaPasta
approved these changes
Apr 28, 2022
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit
@UdjinM6
UdjinM6
merged commit b22d589
into
dashpay:developApr 28, 2022
PastaPastaPasta pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 18, 2022
@UdjinM6@PastaPastaPasta
Merge pull requestdashpay#4817from UdjinM6/drop_0
1d2c9da
build: switch to classical `major.minor.patch` semver
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6@PastaPastaPasta@laanwj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
build: switch to classical `major.minor.patch` semver by UdjinM6 · Pull Request #4817 · dashpay/dash · GitHub
Skip to content
build: switch to classical major.minor.patch semver - #4817
Merged
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Apr 28, 2022
Merged
build: switch to classical major.minor.patch semver#4817
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Apr 28, 2022

Copy link


Copy Markdown

#4768 follow-up
I believe it's better to do it this way cause it makes CLIENT_VERSION comparable again (4768 bumped it +1000000 while normally major versions bump it +10000).
MarcoFalkeand others
added 2 commits
April 28, 2022 13:47
MarcoFalke@UdjinM6
Mergebitcoin#20223: build: Drop the leading 0 from the version number
a3a7a22
8f7b930 Drop the leading 0 from the version number (Andrew Chow)
Pull request description:
Removes the leading 0 from the version number. The minor version, which we had been using as the major version, is now the major version. The revision, which we had been using as the minor version, is now the minor version. The revision number is dropped. The build number is promoted to being part of the version number. This also avoids issues where it was accidentally not included in the version number.
The CLIENT_VERSION remains the same format as previous as previously, as the Major version was 0 so it never actually got included in it.
The user agent string formatter is updated to follow this new versioning.
***
Honestly I'm just tired of all of the people asking for "1.0" that maybe this'll shut them up. Skip the whole 1.0 thing and go straight to version 22.0!
Also, this means that the terminology we commonly use lines up with how the variables are named. So major versions are actually bumping the major version number, etc.
ACKs for top commit:
jnewbery:
Code review ACK 8f7b930
MarcoFalke:
review ACK 8f7b930 🎻
Tree-SHA512: b5c3fae14d4c0a9c0ab3b1db7c949ecc0ac3537646306b13d98dd0efc17c489cdd16d43f0a24aaa28e9c4a92ea360500e05480a335b03f9fb308010cdd93a436
@laanwj@UdjinM6
Mergebitcoin#20449: build: Fix Windows installer build
a064b4c
68c2ef1 Fix version string in Windows and Mac installers (Andrew Chow)
Pull request description:
Apparently NSIS requires a 4 digit version number, and bitcoin#20223 dropped the 4th digit. So this adds a 4th 0 digit so that building the Windows installer doesn't fail. Also fixes a typo in that version string that was also present in a plist file.
ACKs for top commit:
fanquake:
ACK 68c2ef1
laanwj:
Code review ACK 68c2ef1
hebasto:
Approach ACK 68c2ef1, tested on Linux Mint 20 (x86_64, nsis 3.05-2).
Tree-SHA512: 845560ff176eae8081096426790c928a773fa75d366f42a2a4631c1be2ae9234d7a5b72854ccfaa7fa1a32002b937ca393b12168ffacf9a5e3e311a76725483a
@UdjinM6UdjinM6
added this to the 18 milestone
Apr 28, 2022
PastaPastaPasta
PastaPastaPasta
approved these changes
Apr 28, 2022
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit
@UdjinM6
UdjinM6
merged commit b22d589
into
dashpay:developApr 28, 2022
PastaPastaPasta pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 18, 2022
@UdjinM6@PastaPastaPasta
Merge pull requestdashpay#4817from UdjinM6/drop_0
1d2c9da
build: switch to classical `major.minor.patch` semver
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6@PastaPastaPasta@laanwj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
build: switch to classical `major.minor.patch` semver by UdjinM6 · Pull Request #4817 · dashpay/dash · GitHub
Skip to content
build: switch to classical major.minor.patch semver - #4817
Merged
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Apr 28, 2022
Merged
build: switch to classical major.minor.patch semver#4817
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Apr 28, 2022

Copy link


Copy Markdown

#4768 follow-up
I believe it's better to do it this way cause it makes CLIENT_VERSION comparable again (4768 bumped it +1000000 while normally major versions bump it +10000).
MarcoFalkeand others
added 2 commits
April 28, 2022 13:47
MarcoFalke@UdjinM6
Mergebitcoin#20223: build: Drop the leading 0 from the version number
a3a7a22
8f7b930 Drop the leading 0 from the version number (Andrew Chow)
Pull request description:
Removes the leading 0 from the version number. The minor version, which we had been using as the major version, is now the major version. The revision, which we had been using as the minor version, is now the minor version. The revision number is dropped. The build number is promoted to being part of the version number. This also avoids issues where it was accidentally not included in the version number.
The CLIENT_VERSION remains the same format as previous as previously, as the Major version was 0 so it never actually got included in it.
The user agent string formatter is updated to follow this new versioning.
***
Honestly I'm just tired of all of the people asking for "1.0" that maybe this'll shut them up. Skip the whole 1.0 thing and go straight to version 22.0!
Also, this means that the terminology we commonly use lines up with how the variables are named. So major versions are actually bumping the major version number, etc.
ACKs for top commit:
jnewbery:
Code review ACK 8f7b930
MarcoFalke:
review ACK 8f7b930 🎻
Tree-SHA512: b5c3fae14d4c0a9c0ab3b1db7c949ecc0ac3537646306b13d98dd0efc17c489cdd16d43f0a24aaa28e9c4a92ea360500e05480a335b03f9fb308010cdd93a436
@laanwj@UdjinM6
Mergebitcoin#20449: build: Fix Windows installer build
a064b4c
68c2ef1 Fix version string in Windows and Mac installers (Andrew Chow)
Pull request description:
Apparently NSIS requires a 4 digit version number, and bitcoin#20223 dropped the 4th digit. So this adds a 4th 0 digit so that building the Windows installer doesn't fail. Also fixes a typo in that version string that was also present in a plist file.
ACKs for top commit:
fanquake:
ACK 68c2ef1
laanwj:
Code review ACK 68c2ef1
hebasto:
Approach ACK 68c2ef1, tested on Linux Mint 20 (x86_64, nsis 3.05-2).
Tree-SHA512: 845560ff176eae8081096426790c928a773fa75d366f42a2a4631c1be2ae9234d7a5b72854ccfaa7fa1a32002b937ca393b12168ffacf9a5e3e311a76725483a
@UdjinM6UdjinM6
added this to the 18 milestone
Apr 28, 2022
PastaPastaPasta
PastaPastaPasta
approved these changes
Apr 28, 2022
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit
@UdjinM6
UdjinM6
merged commit b22d589
into
dashpay:developApr 28, 2022
PastaPastaPasta pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 18, 2022
@UdjinM6@PastaPastaPasta
Merge pull requestdashpay#4817from UdjinM6/drop_0
1d2c9da
build: switch to classical `major.minor.patch` semver
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6@PastaPastaPasta@laanwj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
build: switch to classical `major.minor.patch` semver by UdjinM6 · Pull Request #4817 · dashpay/dash · GitHub
Skip to content
build: switch to classical major.minor.patch semver - #4817
Merged
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Apr 28, 2022
Merged
build: switch to classical major.minor.patch semver#4817
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Apr 28, 2022

Copy link


Copy Markdown

#4768 follow-up
I believe it's better to do it this way cause it makes CLIENT_VERSION comparable again (4768 bumped it +1000000 while normally major versions bump it +10000).
MarcoFalkeand others
added 2 commits
April 28, 2022 13:47
MarcoFalke@UdjinM6
Mergebitcoin#20223: build: Drop the leading 0 from the version number
a3a7a22
8f7b930 Drop the leading 0 from the version number (Andrew Chow)
Pull request description:
Removes the leading 0 from the version number. The minor version, which we had been using as the major version, is now the major version. The revision, which we had been using as the minor version, is now the minor version. The revision number is dropped. The build number is promoted to being part of the version number. This also avoids issues where it was accidentally not included in the version number.
The CLIENT_VERSION remains the same format as previous as previously, as the Major version was 0 so it never actually got included in it.
The user agent string formatter is updated to follow this new versioning.
***
Honestly I'm just tired of all of the people asking for "1.0" that maybe this'll shut them up. Skip the whole 1.0 thing and go straight to version 22.0!
Also, this means that the terminology we commonly use lines up with how the variables are named. So major versions are actually bumping the major version number, etc.
ACKs for top commit:
jnewbery:
Code review ACK 8f7b930
MarcoFalke:
review ACK 8f7b930 🎻
Tree-SHA512: b5c3fae14d4c0a9c0ab3b1db7c949ecc0ac3537646306b13d98dd0efc17c489cdd16d43f0a24aaa28e9c4a92ea360500e05480a335b03f9fb308010cdd93a436
@laanwj@UdjinM6
Mergebitcoin#20449: build: Fix Windows installer build
a064b4c
68c2ef1 Fix version string in Windows and Mac installers (Andrew Chow)
Pull request description:
Apparently NSIS requires a 4 digit version number, and bitcoin#20223 dropped the 4th digit. So this adds a 4th 0 digit so that building the Windows installer doesn't fail. Also fixes a typo in that version string that was also present in a plist file.
ACKs for top commit:
fanquake:
ACK 68c2ef1
laanwj:
Code review ACK 68c2ef1
hebasto:
Approach ACK 68c2ef1, tested on Linux Mint 20 (x86_64, nsis 3.05-2).
Tree-SHA512: 845560ff176eae8081096426790c928a773fa75d366f42a2a4631c1be2ae9234d7a5b72854ccfaa7fa1a32002b937ca393b12168ffacf9a5e3e311a76725483a
@UdjinM6UdjinM6
added this to the 18 milestone
Apr 28, 2022
PastaPastaPasta
PastaPastaPasta
approved these changes
Apr 28, 2022
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit
@UdjinM6
UdjinM6
merged commit b22d589
into
dashpay:developApr 28, 2022
PastaPastaPasta pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 18, 2022
@UdjinM6@PastaPastaPasta
Merge pull requestdashpay#4817from UdjinM6/drop_0
1d2c9da
build: switch to classical `major.minor.patch` semver
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6@PastaPastaPasta@laanwj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
build: switch to classical `major.minor.patch` semver by UdjinM6 · Pull Request #4817 · dashpay/dash · GitHub
Skip to content
build: switch to classical major.minor.patch semver - #4817
Merged
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Apr 28, 2022
Merged
build: switch to classical major.minor.patch semver#4817
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Apr 28, 2022

Copy link


Copy Markdown

#4768 follow-up
I believe it's better to do it this way cause it makes CLIENT_VERSION comparable again (4768 bumped it +1000000 while normally major versions bump it +10000).
MarcoFalkeand others
added 2 commits
April 28, 2022 13:47
MarcoFalke@UdjinM6
Mergebitcoin#20223: build: Drop the leading 0 from the version number
a3a7a22
8f7b930 Drop the leading 0 from the version number (Andrew Chow)
Pull request description:
Removes the leading 0 from the version number. The minor version, which we had been using as the major version, is now the major version. The revision, which we had been using as the minor version, is now the minor version. The revision number is dropped. The build number is promoted to being part of the version number. This also avoids issues where it was accidentally not included in the version number.
The CLIENT_VERSION remains the same format as previous as previously, as the Major version was 0 so it never actually got included in it.
The user agent string formatter is updated to follow this new versioning.
***
Honestly I'm just tired of all of the people asking for "1.0" that maybe this'll shut them up. Skip the whole 1.0 thing and go straight to version 22.0!
Also, this means that the terminology we commonly use lines up with how the variables are named. So major versions are actually bumping the major version number, etc.
ACKs for top commit:
jnewbery:
Code review ACK 8f7b930
MarcoFalke:
review ACK 8f7b930 🎻
Tree-SHA512: b5c3fae14d4c0a9c0ab3b1db7c949ecc0ac3537646306b13d98dd0efc17c489cdd16d43f0a24aaa28e9c4a92ea360500e05480a335b03f9fb308010cdd93a436
@laanwj@UdjinM6
Mergebitcoin#20449: build: Fix Windows installer build
a064b4c
68c2ef1 Fix version string in Windows and Mac installers (Andrew Chow)
Pull request description:
Apparently NSIS requires a 4 digit version number, and bitcoin#20223 dropped the 4th digit. So this adds a 4th 0 digit so that building the Windows installer doesn't fail. Also fixes a typo in that version string that was also present in a plist file.
ACKs for top commit:
fanquake:
ACK 68c2ef1
laanwj:
Code review ACK 68c2ef1
hebasto:
Approach ACK 68c2ef1, tested on Linux Mint 20 (x86_64, nsis 3.05-2).
Tree-SHA512: 845560ff176eae8081096426790c928a773fa75d366f42a2a4631c1be2ae9234d7a5b72854ccfaa7fa1a32002b937ca393b12168ffacf9a5e3e311a76725483a
@UdjinM6UdjinM6
added this to the 18 milestone
Apr 28, 2022
PastaPastaPasta
PastaPastaPasta
approved these changes
Apr 28, 2022
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit
@UdjinM6
UdjinM6
merged commit b22d589
into
dashpay:developApr 28, 2022
PastaPastaPasta pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 18, 2022
@UdjinM6@PastaPastaPasta
Merge pull requestdashpay#4817from UdjinM6/drop_0
1d2c9da
build: switch to classical `major.minor.patch` semver
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6@PastaPastaPasta@laanwj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
build: switch to classical `major.minor.patch` semver by UdjinM6 · Pull Request #4817 · dashpay/dash · GitHub
Skip to content
build: switch to classical major.minor.patch semver - #4817
Merged
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Apr 28, 2022
Merged
build: switch to classical major.minor.patch semver#4817
UdjinM6 merged 2 commits into
dashpay:developfrom 
UdjinM6:drop_0
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Apr 28, 2022

Copy link


Copy Markdown

#4768 follow-up
I believe it's better to do it this way cause it makes CLIENT_VERSION comparable again (4768 bumped it +1000000 while normally major versions bump it +10000).
MarcoFalkeand others
added 2 commits
April 28, 2022 13:47
MarcoFalke@UdjinM6
Mergebitcoin#20223: build: Drop the leading 0 from the version number
a3a7a22
8f7b930 Drop the leading 0 from the version number (Andrew Chow)
Pull request description:
Removes the leading 0 from the version number. The minor version, which we had been using as the major version, is now the major version. The revision, which we had been using as the minor version, is now the minor version. The revision number is dropped. The build number is promoted to being part of the version number. This also avoids issues where it was accidentally not included in the version number.
The CLIENT_VERSION remains the same format as previous as previously, as the Major version was 0 so it never actually got included in it.
The user agent string formatter is updated to follow this new versioning.
***
Honestly I'm just tired of all of the people asking for "1.0" that maybe this'll shut them up. Skip the whole 1.0 thing and go straight to version 22.0!
Also, this means that the terminology we commonly use lines up with how the variables are named. So major versions are actually bumping the major version number, etc.
ACKs for top commit:
jnewbery:
Code review ACK 8f7b930
MarcoFalke:
review ACK 8f7b930 🎻
Tree-SHA512: b5c3fae14d4c0a9c0ab3b1db7c949ecc0ac3537646306b13d98dd0efc17c489cdd16d43f0a24aaa28e9c4a92ea360500e05480a335b03f9fb308010cdd93a436
@laanwj@UdjinM6
Mergebitcoin#20449: build: Fix Windows installer build
a064b4c
68c2ef1 Fix version string in Windows and Mac installers (Andrew Chow)
Pull request description:
Apparently NSIS requires a 4 digit version number, and bitcoin#20223 dropped the 4th digit. So this adds a 4th 0 digit so that building the Windows installer doesn't fail. Also fixes a typo in that version string that was also present in a plist file.
ACKs for top commit:
fanquake:
ACK 68c2ef1
laanwj:
Code review ACK 68c2ef1
hebasto:
Approach ACK 68c2ef1, tested on Linux Mint 20 (x86_64, nsis 3.05-2).
Tree-SHA512: 845560ff176eae8081096426790c928a773fa75d366f42a2a4631c1be2ae9234d7a5b72854ccfaa7fa1a32002b937ca393b12168ffacf9a5e3e311a76725483a
@UdjinM6UdjinM6
added this to the 18 milestone
Apr 28, 2022
PastaPastaPasta
PastaPastaPasta
approved these changes
Apr 28, 2022
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit
@UdjinM6
UdjinM6
merged commit b22d589
into
dashpay:developApr 28, 2022
PastaPastaPasta pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 18, 2022
@UdjinM6@PastaPastaPasta
Merge pull requestdashpay#4817from UdjinM6/drop_0
1d2c9da
build: switch to classical `major.minor.patch` semver
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6@PastaPastaPasta@laanwj