fix!: mn_rr features only for v21+

[knst]

Issue being fixed or feature implemented

Should not be 2 forks in one version

What was done?

• Asset Unlock transactions (withdrawals) should be available only in MN_RR fork
• MN_RR should not be auto-activated on Main net without intentional release of code (and not by spork), but they are need on test net to test platform.

How Has This Been Tested?

Run unit/functional tests

Breaking Changes

Yes (see "what was done")

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone

[PastaPastaPasta]

utACK for squash merge; this looks correct to me

[UdjinM6]

MN_RR should not be auto-activated on Main net without intentional release of code (and not by spork), but they are need on test net to test platform

so is SPORK_24_EHF not longer need or is it a non-mainnet only spork now?

[PastaPastaPasta]

MN_RR should not be auto-activated on Main net without intentional release of code (and not by spork), but they are need on test net to test platform

so is SPORK_24_EHF not longer need or is it a non-mainnet only spork now?

Basically non-main net only, a value could still be set; but it doesn't (shouldn't) affect anything on mainnet

[knst]

so is SPORK_24_EHF not longer need or is it a non-mainnet only spork now?

This spork has been introduced to prevent activation of mn_rr before platform is ready.

As discussed today:

• Asset Unlock transaction is not tested properly on testnet yet; not tested properly feature should not be potentially active on mainnet; also it may require consensus rules to chage
• 2 forks are confusing for dash users. Let's keep the rule "1 major version = 1 hard-fork"
• activation of a hard fork by spork is it bad idea; because it should relay on user's update, not DCG command to do anything.

So, mn_rr requires a new release v21 or v20.1; the spork maybe even dropped then.

For testnet it is needed for platform's need + to test EHF mechanism.

[UdjinM6]

utACK

[PastaPastaPasta]

Issue created here: #5644

[PastaPastaPasta]

utACK for squash merge