Skip to content

fix(qt): tab switching via shortcuts doesn't work after 5986 - #5995

Merged
1 commit merged into
dashpay:developfrom
UdjinM6:fix_updateButtonGroupShortcuts
Apr 26, 2024
Merged

fix(qt): tab switching via shortcuts doesn't work after 5986#5995
1 commit merged into
dashpay:developfrom
UdjinM6:fix_updateButtonGroupShortcuts

Conversation

@UdjinM6

Copy link
Copy Markdown

Issue being fixed or feature implemented

Looks like 3265b54 (#5986) broke it

What was done?

How Has This Been Tested?

run dash-qt, try using shortcuts cmd+1, cmd+2 etc. (on macos)

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6UdjinM6 added this to the 21 milestone Apr 24, 2024
@UdjinM6UdjinM6 changed the title fix(qt): tab switching via Ctrl+<N> doesn't work after 5986fix(qt): tab switching via shortcuts doesn't work after 5986Apr 24, 2024
@UdjinM6
UdjinM6force-pushed the fix_updateButtonGroupShortcuts branch from 419c6df to c874205CompareApril 24, 2024 12:07
@PastaPastaPasta

Copy link
Copy Markdown
Member

Whoops he had asked me to test that 🙈

@PastaPastaPastaPastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwvgkwvg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubuntu 20.04, works fine

ACK c874205

@PastaPastaPastaPastaPastaPasta closed this pull request by merging all changes into dashpay:develop in b1852e0Apr 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6@PastaPastaPasta@kwvg