Uh oh!
There was an error while loading. Please reload this page.
backport: Merge bitcoin#22619, 22593 - #6071
Merged
Merged
Conversation
vijaydasmpforce-pushed
the
bp23_98
branch
3 times, most recently
from
June 22, 2024 01:27
d1bf903 to
969a9edCompareThis pull request has conflicts, please rebase. |
vijaydasmpforce-pushed
the
bp23_98
branch
4 times, most recently
from
July 7, 2024 07:12
38bf780 to
bb5cfccComparevijaydasmpforce-pushed
the
bp23_98
branch
6 times, most recently
from
July 19, 2024 16:36
e5bc737 to
0020e72Comparevijaydasmp
marked this pull request as ready for review
July 21, 2024 03:06
vijaydasmp
commented
Jul 22, 2024
Author
Hello @UdjinM6 , @knst , @PastaPastaPasta for review |
knst
reviewed
Jul 23, 2024
Collaborator
There was a problem hiding this comment.
22570 has been already released with version Dash Core v20: #5574
without release notes, too late to update it now.
DNM 22603
UdjinM6
previously approved these changes
Aug 5, 2024
UdjinM6
left a comment
There was a problem hiding this comment.
utACK 26ec2e4a14045291c96c7e2dc04db9c318599977
This pull request has conflicts, please rebase. |
vijaydasmp
commented
Aug 9, 2024
Author
had to rebase , requesting re-review |
vijaydasmp
marked this pull request as draft
August 10, 2024 12:52
vijaydasmpforce-pushed
the
bp23_98
branch
2 times, most recently
from
August 17, 2024 02:30
86fb13f to
431a82fComparevijaydasmp
marked this pull request as ready for review
August 17, 2024 02:33
vijaydasmpforce-pushed
the
bp23_98
branch
2 times, most recently
from
August 21, 2024 00:40
16c39fe to
f9bfc35CompareUdjinM6
requested changes
Aug 21, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
UdjinM6
approved these changes
Aug 22, 2024
UdjinM6
left a comment
There was a problem hiding this comment.
utACK a6ec9bcc3793e0579ee039a204c6d971cfbc797e
vijaydasmp
commented
Aug 22, 2024
Author
Hello @PastaPastaPasta, requesting review |
…ing conversion in functional test framework 5a1bef6 test: refactor: remove binascii from test_framework (Zero-1729) Pull request description: This PR continues the work started in PR bitcoin#22593, regarding using the `bytes` built-in module. In this PR specifically, instances of `binascii`'s methods `hexlify`, `unhexlify`, and `a2b_hex` have been replaced with the build-in `bytes` module's `hex` and `fromhex` methods where appropriate to make bytes <-> hex-string conversions consistent across the functional test files and test_framework. Additionally, certain changes made are based on the following assumption: ``` bytes.hex(data) == binascii.hexlify(data).decode() bytes.hex(data).encode() == binascii.hexlify(data) ``` Ran the functional tests to ensure behaviour is still consistent and changes didn't break existing tests. closesbitcoin#22605 ACKs for top commit: theStack: Code-review ACK 5a1bef6 🔢 Tree-SHA512: 8f28076cf0580a0d02a156f3e1e94c9badd3d41c3fbdfb2b87cd8a761dde2c94faa5f4c448d6747b1ccc9111c3ef1a1d7b42a11c806b241fa0410b7529e2445f Signed-off-by: Vijay <vijaydas.mp@gmail.com>
Signed-off-by: Vijay <vijaydas.mp@gmail.com>
knst
approved these changes
Aug 27, 2024
kwvg
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bitcoin backports