backport: Merge bitcoin/bitcoin#28136, 27581, 18919, 25634, 25284, 27829

[vijaydasmp]

Backports

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[github-actions]

This pull request has conflicts, please rebase.

[github-actions]

This pull request has conflicts, please rebase.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c0f42a and b39ec50.

📒 Files selected for processing (20)

• src/addrman.cpp
• src/addrman.h
• src/addrman_impl.h
• src/httprpc.cpp
• src/net.cpp
• src/net.h
• src/netgroup.cpp
• src/netgroup.h
• src/rest.cpp
• src/rpc/mempool.cpp
• src/rpc/net.cpp
• src/rpc/rawtransaction.cpp
• src/rpc/util.cpp
• src/rpc/util.h
• src/test/addrman_tests.cpp
• src/test/fuzz/addrman.cpp
• src/test/fuzz/connman.cpp
• src/wallet/rpc/spend.cpp
• test/functional/feature_asmap.py
• test/functional/wallet_listtransactions.py

💤 Files with no reviewable changes (2)

• src/rpc/util.cpp
• src/rpc/util.h

---

Walkthrough

This pull request introduces a filtered parameter to address retrieval methods across the address manager and network connection interfaces, enabling callers to optionally disable filtering of "terrible" addresses. It adds ASMap health check functionality that validates ASMap effectiveness by collecting and analyzing address-to-ASN mappings during startup. The PR also relocates the GetServicesNames helper function from rpc/util to rpc/net to consolidate service-related RPC utilities. Additional changes include RPC documentation refinements, new include directives, and test cases validating unfiltered address retrieval and ASMap health check behavior.

Sequence Diagram(s)

sequenceDiagram
participant Startup as Startup Process
participant Connman as CConnman
participant AddrMan as AddrMan
participant NetGroup as NetGroupManager
participant Log as Debug Log
Startup->>Connman: Initialize (if ASMap enabled)
Connman->>Connman: Schedule ASMapHealthCheck
Connman->>Connman: ASMapHealthCheck()
Connman->>AddrMan: GetAddresses(IPv4, filtered=false)
AddrMan-->>Connman: addresses (including terrible)
Connman->>AddrMan: GetAddresses(IPv6, filtered=false)
AddrMan-->>Connman: addresses (including terrible)
Connman->>NetGroup: ASMapHealthCheck(clearnet_addrs)
NetGroup->>NetGroup: Map each address to ASN
NetGroup->>NetGroup: Count unmapped, collect ASNs
NetGroup->>Log: Log health summary

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The description 'Backports' is very minimal and generic, using a non-descriptive term that conveys no meaningful information about which specific changes or features are being backported or what their purposes are.	Expand the description to identify key changes being backported, such as ASMap health checks, address filtering logic, and RPC refactoring, to give reviewers context.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly references specific Bitcoin upstream PRs (#28136, 27581, 18919, 25634, 25284, 27829) being backported, which matches the diverse changes across address management, ASMap health checks, RPC refactoring, and test additions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vijaydasmp]

Hello @knst@UdjinM6 , requesting review

[UdjinM6]

utACK b39ec50

[thepastaclaw]

Review Gate

Commit: b39ec50f

• ✅ Debounce: 46270m ago (need 30m)

• ⏳ CI checks: check(s) failed

• ✅ CodeRabbit review: comment found

• Run review now (check to override)