Uh oh!
There was an error while loading. Please reload this page.
Backport bugfixes for CMasternodeMan::CheckAndRemove and smartfee (+test) - #738
Closed
UdjinM6 wants to merge 1 commit into
Closed
Backport bugfixes for CMasternodeMan::CheckAndRemove and smartfee (+test)#738UdjinM6 wants to merge 1 commit into
CMasternodeMan::CheckAndRemove and smartfee (+test)#738UdjinM6 wants to merge 1 commit into
Conversation
CMasternodeMan::CheckAndRemove and smartfee (+test)CMasternodeMan::CheckAndRemove and smartfee (+test)schinzelh pushed a commit
that referenced
this pull request
Mar 16, 2016
schinzelh
commented
Mar 16, 2016
Merged to 0.12.0.x - please do not create PRs against master, only against version/feature branches :) |
schinzelh
commented
Mar 16, 2016
Is #737 worth backporting too in this context? |
UdjinM6
commented
Mar 16, 2016
Author
5 tasks
PastaPastaPasta added a commit
that referenced
this pull request
Aug 23, 2026
56a61c8 Merge bitcoin#26740: wallet: Migrate wallets that are not in a wallet dir (Konstantin Akimov) 493f633 fix: follow-up backporting bitcoin#17261 - missing break (Konstantin Akimov) 087c9be Merge bitcoin#26638: test: prefer sqlite for wallet tests (Konstantin Akimov) 117dab2 Merge bitcoin-core/gui#738: Add menu option to migrate a wallet (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented Further improvements of `migratewallet` RPC to migrate legacy wallets to descriptor wallets. ## What was done? Backports: - bitcoin-core/gui#738 - bitcoin#26638 - bitcoin#26740 + fix for old backport bitcoin#17261 Further changes to be done in the next batch ; out-of-scope of current PR: - bitcoin-core/gui#824 (fix for #738), depends on bitcoin#27790 - bitcoin#26021 (depends on #7037) - bitcoin#28067 (depends on 26021) - bitcoin#28038 (depends on 27217) - bitcoin#28125 - bitcoin#28602 - bitcoin#28609 [currently doesn't work as expected, probably depends on 28125] - bitcoin#28546 - bitcoin#28868 ## How Has This Been Tested? Run unit test & functional tests. Click in Qt-UI "Migrate wallet" - it works as expected. ## Breaking Changes None ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: 7f14fe3ac06f1fe62f99bc2775007f92c26886dcbd2cb6fcc9c122ca8a515f5b6b78768cc6626c26b55b7c29102bf896834df950f98b2aee0915c7e8a65b124d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckAndRemovefix should help masternoders, smartfee fix should help guys like this one https://dashtalk.org/threads/fees.8322/