Uh oh!
There was an error while loading. Please reload this page.
docs: document the dash analogue of BIP143 - #149
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
panleone
commented
Feb 11, 2024
Reviews applied and updated the test to make it consistent with the new approach |
thephez
left a comment
There was a problem hiding this comment.
Thanks for the work on this! I've added a few suggestions.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
panleone
commented
Feb 23, 2024
thanks for the review, I have applied your suggestions |
Alternative to the old PR #95
This PR describes how the transaction sighash algorithm of BIP143 can be adapted to dash. There are only 2 main differences:
nTypeandvExtraPayloadnVersion = 4and it's deployed with an ehf hard fork.The example in the test section was created with a draft implementation of the algorithm (see dashpay/dash#5860)