Skip to content

DIP 22: Deterministic InstantSend - #98

Merged
thephez merged 18 commits into
masterfrom
deterministic-instantsend
Nov 4, 2021
Merged

DIP 22: Deterministic InstantSend#98
thephez merged 18 commits into
masterfrom
deterministic-instantsend

Conversation

@thephez

@thephezthephez commented Aug 3, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

This DIP aims to improve InstantSend messages to make them deterministically verifiable.

Link to doc: https://github.com/dashpay/dips/blob/deterministic-instantsend/dip-0022.md

Thanks to @QuantumExplorer and @UdjinM6 for collaborating on this

thephez
thephez commented Aug 3, 2021
View reviewed changes

@thephezthephez left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions for @QuantumExplorer and @UdjinM6

Comment threaddeterministic-instantsend.md Outdated
Comment threaddeterministic-instantsend.md
@thephez
thephez marked this pull request as ready for review August 31, 2021 17:44
thephez
thephez commented Oct 7, 2021
View reviewed changes
Comment threaddeterministic-instantsend.md Outdated
thephez
thephez commented Oct 7, 2021
View reviewed changes
Comment threaddeterministic-instantsend.md Outdated
VirgileBa
VirgileBa reviewed Oct 7, 2021
View reviewed changes
Comment threaddeterministic-instantsend.md Outdated
3. For each LLMQ of this quorum cycle’s set, calculate `SHA256(quorumType, quorumHash, requestId)`
4. Sort the list of LLMQs based on the result of step 3 in ascending order
5. Use the first entry of the sorted list as the responsible LLMQ
6. Create the SignID by calculating `SHA256(quorumHash, requestId, SHA256(version, txHash))`

@VirgileBaVirgileBaOct 7, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
6. Create the SignID by calculating `SHA256(quorumHash, requestId, SHA256(version, txHash))`
6. Create the SignID by calculating `SHA256(quorumHash, requestId)`

thephez
thephez commented Oct 7, 2021
View reviewed changes
Comment threaddeterministic-instantsend.md
@thephez
thephezforce-pushed the deterministic-instantsend branch from cdc11a3 to bc36b71CompareOctober 11, 2021 13:15
gabriel-bjg
gabriel-bjg reviewed Oct 11, 2021
View reviewed changes
Comment threaddip-0022.md Outdated
@thephez@gabriel-bjg
Update dip-0022.md
5969c7e
Co-authored-by: gabriel-bjg <gabriel.bjg@gmail.com>
@thephezthephez changed the title Draft DIP: Deterministic InstantSendDIP 22: Deterministic InstantSendOct 11, 2021
@thephez

thephez commented Oct 19, 2021

Copy link
Copy Markdown
CollaboratorAuthor

@PastaPastaPasta@QuantumExplorer@UdjinM6 Please complete a final review on this so we can merge it. 🙏

UdjinM6
UdjinM6 previously approved these changes Oct 21, 2021
View reviewed changes
@thephez

thephez commented Oct 25, 2021

Copy link
Copy Markdown
CollaboratorAuthor

@PastaPastaPasta@QuantumExplorer@UdjinM6 Please complete a final review on this so we can merge it. pray

@PastaPastaPasta@QuantumExplorer Please complete a final review on this so we can merge it. 🙏

@thephez
thephez merged commit 35d326e into masterNov 4, 2021
@thephez
thephez deleted the deterministic-instantsend branch November 4, 2021 12:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6UdjinM6UdjinM6 approved these changes
@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes
@QuantumExplorerQuantumExplorerAwaiting requested review from QuantumExplorer
+2 more reviewers
@gabriel-bjggabriel-bjggabriel-bjg left review comments
@VirgileBaVirgileBaVirgileBa left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@QuantumExplorerQuantumExplorer

Labels

Type: Standards

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thephez@UdjinM6@PastaPastaPasta@gabriel-bjg@VirgileBa@QuantumExplorer