Uh oh!
There was an error while loading. Please reload this page.
chore: remove use of deprecated docker-compose - #137
Merged
Conversation
strophy
marked this pull request as ready for review
July 13, 2022 07:05
strophy
marked this pull request as draft
July 13, 2022 07:15
strophy
commented
Jul 13, 2022
CollaboratorAuthor
Docker Compose V2 will be supported in Platform 0.23, so we need to wait for that release to merge this now. |
thephez
commented
Nov 16, 2022
Collaborator
@strophy Are we waiting for the actual v0.23 release? Or is this able to be merged now? |
strophy
commented
Nov 17, 2022
CollaboratorAuthor
We're still waiting for release afaik, but I think we could merge this already since testnet is already running v0.23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
docker-composerequirement. Docker Compose V1 (Python) has been deprecated and replaced with Docker Compose V2 (Go) which now ships by default with both Docker Desktop and the convenience script we use to install Docker on Linux. This PR can be merged when support for Docker Compose V2 is merged into Dashmate (dashevo/platform #422).