Skip to content

feat(drive): network address in ValidatorUpdate ABCI - #140

Merged
shuplenkov merged 8 commits into
v0.22-devfrom
validator-set
Dec 21, 2021
Merged

feat(drive): network address in ValidatorUpdate ABCI#140
shuplenkov merged 8 commits into
v0.22-devfrom
validator-set

Conversation

@shuplenkov

@shuplenkovshuplenkov commented Dec 17, 2021

Copy link
Copy Markdown

Issue being fixed or feature implemented

In the current implementation, the ABCI application manages the rotation of Validator Sets. When rotation is needed, the application sends information about the new Validator Set in response to the EndBlock message. EndBlock message shall be extended by adding a network address of each Validator node.

What was done?

EndBlock message was extended by adding a network address of each Validator node.

How Has This Been Tested?

With tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkovshuplenkov changed the title validator-setfeat(drive): add network address to validator dataDec 17, 2021
@shuplenkovshuplenkov added this to the v0.22.0 milestone Dec 17, 2021
@shuplenkov
shuplenkov marked this pull request as ready for review December 20, 2021 12:37
Comment threadpackages/js-drive/lib/createDIContainer.js Outdated
Comment threadpackages/js-drive/lib/validator/ValidatorSet.js Outdated
@shumkov

Copy link
Copy Markdown
Collaborator

Comment threadpackages/js-drive/lib/validator/Validator.js Outdated

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update Tenderdash image to 0.7.0-dev.4

@shumkovshumkov changed the title feat(drive): add network address to validator datafeat(drive): pass network address to validators set update ABCIDec 21, 2021
@shumkovshumkov changed the title feat(drive): pass network address to validators set update ABCIfeat(drive): network address in ValidatorsSetUpdate ABCIDec 21, 2021
@shumkovshumkov changed the title feat(drive): network address in ValidatorsSetUpdate ABCIfeat(drive): network address in ValidatorUpdate ABCIDec 21, 2021

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shuplenkov
shuplenkov merged commit 9e01742 into v0.22-devDec 21, 2021
@shuplenkov
shuplenkov deleted the validator-set branch December 21, 2021 13:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shuplenkov@shumkov