Skip to content

chore: update to use current @oclif/core - #154

Merged
strophy merged 11 commits into
v0.22-devfrom
chore/update-oclif-core
Dec 30, 2021
Merged

chore: update to use current @oclif/core#154
strophy merged 11 commits into
v0.22-devfrom
chore/update-oclif-core

Conversation

@strophy

@strophystrophy commented Dec 23, 2021

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

@oclif/core has been released, deprecating the previously used @oclif/command, @oclif/errors and @oclif/config dependencies. We need to update in order to use new functionality such as the oclif pack command.

What was done?

Migrate to @oclif/core following the migration guide.

How Has This Been Tested?

In CI

Breaking Changes

  • We now support using the space character as a topic separator, but dashmate remains backwards compatible with the : colon separator.
  • Requires Node 12+

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophystrophy added this to the v0.22.0 milestone Dec 23, 2021
@strophy
strophy marked this pull request as draft December 23, 2021 16:32
@strophy
strophy marked this pull request as ready for review December 28, 2021 20:08
Comment threadpackages/dashmate/src/commands/setup.js Outdated
@shumkov

Copy link
Copy Markdown
Collaborator

@strophy why so many dependency updates?

@strophy

Copy link
Copy Markdown
ContributorAuthor

@strophy why so many dependency updates?

Probably because I changed the package.json file, which resulted in a lot of dependency updates? Or did I do something incorrectly here, should I commit the zip files or not?

@shumkov

Copy link
Copy Markdown
Collaborator

@strophy Yep, you should.

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@strophy
strophy merged commit e6a8c88 into v0.22-devDec 30, 2021
@strophy
strophy deleted the chore/update-oclif-core branch December 30, 2021 19:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@strophy@shumkov