Uh oh!
There was an error while loading. Please reload this page.
chore: set versions for dash core and grovedb and release 3.0 - #3010
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughBumps many package and workspace manifest versions to final releases, replaces several Git rev pins with tag-based dependencies, consolidates dashmate config migrations into a single 3.0.0 migration (ZMQ, rsDapi metrics/timeouts, gateway upstreams, Letsencrypt), and updates a wallet API/signature and example. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/dashmate/configs/getConfigFileMigrationsFactory.js`:
- Around line 1292-1294: The early `return` that checks `if
(!options.platform?.dapi) { return; }` short-circuits all subsequent 3.0.0
migrations; instead, remove that global return and wrap only the DAPI-specific
migration code in a conditional (e.g., `if (options.platform?.dapi) { /*
dapi-only migrations */ }`) so gateway/drive/quorumList/core RPC and other
non‑DAPI migrations still run; update the block in the
getConfigFileMigrationsFactory migration sequence to scope the guard to DAPI
logic rather than exiting the whole function.
🧹 Nitpick comments (1)
packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
1300-1313: DefaultrsDapi.metrics.hostwhen absent.If a config already has
metricsbut lackshost, it staysundefined. To keep parity with earlier migrations, consider defaultinghosttoo.♻️ Suggested patch
if (typeof options.platform.dapi.rsDapi.metrics.enabled === 'undefined') { options.platform.dapi.rsDapi.metrics.enabled = defaultMetrics.enabled; } + if (typeof options.platform.dapi.rsDapi.metrics.host === 'undefined') {+ options.platform.dapi.rsDapi.metrics.host = defaultMetrics.host;+ }+ if (typeof options.platform.dapi.rsDapi.metrics.port === 'undefined') { options.platform.dapi.rsDapi.metrics.port = defaultMetrics.port; }
Comment on lines
+1292
to
+1294
| if (!options.platform?.dapi) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Avoid short‑circuiting non‑DAPI migrations.
If a config omits platform.dapi, the early return skips later 3.0.0 migrations (gateway/drive/quorumList/core RPC), leaving those configs stale. Consider guarding only the DAPI‑specific block while still running the rest.
🔧 Proposed fix (scope DAPI-only logic)
- if (!options.platform?.dapi) {- return;- }-- if (!options.platform.dapi.rsDapi) {- options.platform.dapi.rsDapi = lodash.cloneDeep(defaultConfig.get('platform.dapi.rsDapi'));- }-- const defaultMetrics = defaultConfig.get('platform.dapi.rsDapi.metrics');- ...- if (options.platform?.dapi?.deprecated) {- delete options.platform.dapi.deprecated;- }+ if (!options.platform) {+ return;+ }++ if (options.platform.dapi) {+ if (!options.platform.dapi.rsDapi) {+ options.platform.dapi.rsDapi = lodash.cloneDeep(defaultConfig.get('platform.dapi.rsDapi'));+ }++ const defaultMetrics = defaultConfig.get('platform.dapi.rsDapi.metrics');+ ...+ if (options.platform.dapi.deprecated) {+ delete options.platform.dapi.deprecated;+ }+ }🤖 Prompt for AI Agents
In `@packages/dashmate/configs/getConfigFileMigrationsFactory.js` around lines
1292 - 1294, The early `return` that checks `if (!options.platform?.dapi) {
return; }` short-circuits all subsequent 3.0.0 migrations; instead, remove that
global return and wrap only the DAPI-specific migration code in a conditional
(e.g., `if (options.platform?.dapi) { /* dapi-only migrations */ }`) so
gateway/drive/quorumList/core RPC and other non‑DAPI migrations still run;
update the block in the getConfigFileMigrationsFactory migration sequence to
scope the guard to DAPI logic rather than exiting the whole function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 3.0 release
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.