Skip to content

docs(wasm-dpp): document no-op user fee increase methods on vote transition - #3209

Merged
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Mar 12, 2026
Merged

docs(wasm-dpp): document no-op user fee increase methods on vote transition#3209
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom
thepastaclaw:docs/wasm-dpp-noop-doc-rebased

Conversation

@thepastaclaw

@thepastaclawthepastaclaw commented Mar 6, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

Add doc comments to the no-op get_user_fee_increase / set_user_fee_increase methods on MasternodeVoteTransitionWasm, explaining they exist for API compatibility and are intentionally no-ops.

This addresses a CodeRabbit nitpick from #3183.

Validation

  • cargo check -p wasm-dpp — compiles clean.
  • Doc-only change, no behavior change.

Summary by CodeRabbit

  • New Features

    • Exposed getter and setter for Masternode vote user fee increase in the WASM API; getter returns 0 and setter is a no-op.

  • Documentation

    • Clarified that user fee increases are not supported for Masternode vote transitions and that the exposed methods are API-compatible stubs with no effect.

@thepastaclaw
docs(wasm-dpp): document no-op user fee increase methods on vote tran…
377ed8a
…sition
Addresses CodeRabbit nitpick on dashpay#3183: adds doc comments
to the getter and setter for user_fee_increase on MasternodeVoteTransition
explaining that these methods are intentional no-ops kept for API compatibility.
@thepastaclaw

thepastaclaw commented Mar 6, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@coderabbitai review

@github-actionsgithub-actionsBot added this to the v3.1.0 milestone Mar 6, 2026
@coderabbitai

coderabbitaiBot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitaiBot commented Mar 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: de855f5e-5c9d-454c-beb6-ea25fd43932f

📥 Commits

Reviewing files that changed from the base of the PR and between 377ed8a and 0fc35b2.

📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
📝 Walkthrough

Walkthrough

Added two wasm-exported methods to MasternodeVoteTransitionWasm: getUserFeeIncrease (returns 0) and setUserFeeIncrease (no-op). Methods are API-compatible stubs; no internal state or other logic was changed.

Changes

Cohort / File(s)Summary
Masternode vote transition
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs		Added #[wasm_bindgen] accessors: getUserFeeIncrease (fn get_user_fee_increase(&self) -> u16) returning 0, and setUserFeeIncrease (fn set_user_fee_increase(&mut self, _user_fee_increase: u16)) as a no-op. No other logic modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 I hop to the code with a cheerful squeak,
Two tiny stubs added, humble and meek,
One returns zero, the other sits still,
Masternode votes unchanged, calm on the hill,
A rabbit's small note for a change soft and meek.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding documentation to no-op user fee increase methods on the Masternode vote transition in wasm-dpp.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitaiBot reviewed Mar 6, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs (1)

226-230: Documentation clearly explains the no-op behavior.

The doc comment accurately describes that this method always returns 0 because Masternode vote transitions don't support user fee increases. The implementation matches the documentation.

Optional: Consider mentioning API compatibility for consistency

The setter's documentation mentions "API compatibility" explicitly. For consistency, you could optionally expand the getter's doc comment:

-/// Masternode vote transitions do not support user fee increase; always returns 0.+/// Masternode vote transitions do not support user fee increase; always returns 0.+/// This method is kept for API compatibility.

This is purely a style suggestion for consistency between getter and setter documentation.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`
around lines 226 - 230, The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`:
- Around line 226-230: The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.
ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9cb0b033-dd57-4093-8df7-9a87908d0211

📥 Commits

Reviewing files that changed from the base of the PR and between c3e0a83 and 377ed8a.

📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs

@thepastaclaw
docs(wasm-dpp): add API compatibility note to getter doc comment
0fc35b2
Address CodeRabbit nitpick: mention API compatibility in
get_user_fee_increase doc comment for consistency with the setter.
@QuantumExplorer
QuantumExplorer marked this pull request as ready for review March 12, 2026 05:08
@QuantumExplorer
QuantumExplorer self-requested a review as a code ownerMarch 12, 2026 05:08
@QuantumExplorer
QuantumExplorer merged commit 72384ab into dashpay:v3.1-devMar 12, 2026
23 of 28 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@QuantumExplorerQuantumExplorerQuantumExplorer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thepastaclaw@QuantumExplorer
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
docs(wasm-dpp): document no-op user fee increase methods on vote transition by thepastaclaw · Pull Request #3209 · dashpay/platform · GitHub
Skip to content
docs(wasm-dpp): document no-op user fee increase methods on vote transition - #3209
Merged
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Mar 12, 2026
Merged
docs(wasm-dpp): document no-op user fee increase methods on vote transition#3209
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Conversation
@thepastaclaw
@thepastaclawthepastaclaw
commented
Mar 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add doc comments to the no-op get_user_fee_increase / set_user_fee_increase methods on MasternodeVoteTransitionWasm, explaining they exist for API compatibility and are intentionally no-ops.
This addresses a CodeRabbit nitpick from #3183.
Validation
  • cargo check -p wasm-dpp — compiles clean.
  • Doc-only change, no behavior change.
Summary by CodeRabbit
  • New Features
    • Exposed getter and setter for Masternode vote user fee increase in the WASM API; getter returns 0 and setter is a no-op.
  • Documentation
    • Clarified that user fee increases are not supported for Masternode vote transitions and that the exposed methods are API-compatible stubs with no effect.
@thepastaclaw
docs(wasm-dpp): document no-op user fee increase methods on vote tran…
377ed8a
…sition
Addresses CodeRabbit nitpick on dashpay#3183: adds doc comments
to the getter and setter for user_fee_increase on MasternodeVoteTransition
explaining that these methods are intentional no-ops kept for API compatibility.
@thepastaclaw
thepastaclaw
commented
Mar 6, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@coderabbitai review
@github-actionsgithub-actionsBot
added this to the v3.1.0 milestone
Mar 6, 2026
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: de855f5e-5c9d-454c-beb6-ea25fd43932f
📥 Commits
Reviewing files that changed from the base of the PR and between 377ed8a and 0fc35b2.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
📝 Walkthrough
Walkthrough
Added two wasm-exported methods to MasternodeVoteTransitionWasm: getUserFeeIncrease (returns 0) and setUserFeeIncrease (no-op). Methods are API-compatible stubs; no internal state or other logic was changed.
Changes
Cohort / File(s)Summary
Masternode vote transition
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs		Added #[wasm_bindgen] accessors: getUserFeeIncrease (fn get_user_fee_increase(&self) -> u16) returning 0, and setUserFeeIncrease (fn set_user_fee_increase(&mut self, _user_fee_increase: u16)) as a no-op. No other logic modified.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Poem
🐰 I hop to the code with a cheerful squeak,

Two tiny stubs added, humble and meek,

One returns zero, the other sits still,

Masternode votes unchanged, calm on the hill,

A rabbit's small note for a change soft and meek.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding documentation to no-op user fee increase methods on the Masternode vote transition in wasm-dpp.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs (1)
226-230: Documentation clearly explains the no-op behavior.
The doc comment accurately describes that this method always returns 0 because Masternode vote transitions don't support user fee increases. The implementation matches the documentation.
Optional: Consider mentioning API compatibility for consistency
The setter's documentation mentions "API compatibility" explicitly. For consistency, you could optionally expand the getter's doc comment:
-/// Masternode vote transitions do not support user fee increase; always returns 0.+/// Masternode vote transitions do not support user fee increase; always returns 0.+/// This method is kept for API compatibility.
This is purely a style suggestion for consistency between getter and setter documentation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`
around lines 226 - 230, The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`:
- Around line 226-230: The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9cb0b033-dd57-4093-8df7-9a87908d0211
📥 Commits
Reviewing files that changed from the base of the PR and between c3e0a83 and 377ed8a.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
@thepastaclaw
docs(wasm-dpp): add API compatibility note to getter doc comment
0fc35b2
Address CodeRabbit nitpick: mention API compatibility in
get_user_fee_increase doc comment for consistency with the setter.
@QuantumExplorer
QuantumExplorer
marked this pull request as ready for review
March 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
self-requested a review
as a code ownerMarch 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
merged commit 72384ab
into
dashpay:v3.1-devMar 12, 2026

23 of 28 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@QuantumExplorerQuantumExplorerQuantumExplorer approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thepastaclaw@QuantumExplorer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs(wasm-dpp): document no-op user fee increase methods on vote transition by thepastaclaw · Pull Request #3209 · dashpay/platform · GitHub
Skip to content
docs(wasm-dpp): document no-op user fee increase methods on vote transition - #3209
Merged
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Mar 12, 2026
Merged
docs(wasm-dpp): document no-op user fee increase methods on vote transition#3209
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Conversation
@thepastaclaw
@thepastaclawthepastaclaw
commented
Mar 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add doc comments to the no-op get_user_fee_increase / set_user_fee_increase methods on MasternodeVoteTransitionWasm, explaining they exist for API compatibility and are intentionally no-ops.
This addresses a CodeRabbit nitpick from #3183.
Validation
  • cargo check -p wasm-dpp — compiles clean.
  • Doc-only change, no behavior change.
Summary by CodeRabbit
  • New Features
    • Exposed getter and setter for Masternode vote user fee increase in the WASM API; getter returns 0 and setter is a no-op.
  • Documentation
    • Clarified that user fee increases are not supported for Masternode vote transitions and that the exposed methods are API-compatible stubs with no effect.
@thepastaclaw
docs(wasm-dpp): document no-op user fee increase methods on vote tran…
377ed8a
…sition
Addresses CodeRabbit nitpick on dashpay#3183: adds doc comments
to the getter and setter for user_fee_increase on MasternodeVoteTransition
explaining that these methods are intentional no-ops kept for API compatibility.
@thepastaclaw
thepastaclaw
commented
Mar 6, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@coderabbitai review
@github-actionsgithub-actionsBot
added this to the v3.1.0 milestone
Mar 6, 2026
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: de855f5e-5c9d-454c-beb6-ea25fd43932f
📥 Commits
Reviewing files that changed from the base of the PR and between 377ed8a and 0fc35b2.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
📝 Walkthrough
Walkthrough
Added two wasm-exported methods to MasternodeVoteTransitionWasm: getUserFeeIncrease (returns 0) and setUserFeeIncrease (no-op). Methods are API-compatible stubs; no internal state or other logic was changed.
Changes
Cohort / File(s)Summary
Masternode vote transition
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs		Added #[wasm_bindgen] accessors: getUserFeeIncrease (fn get_user_fee_increase(&self) -> u16) returning 0, and setUserFeeIncrease (fn set_user_fee_increase(&mut self, _user_fee_increase: u16)) as a no-op. No other logic modified.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Poem
🐰 I hop to the code with a cheerful squeak,

Two tiny stubs added, humble and meek,

One returns zero, the other sits still,

Masternode votes unchanged, calm on the hill,

A rabbit's small note for a change soft and meek.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding documentation to no-op user fee increase methods on the Masternode vote transition in wasm-dpp.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs (1)
226-230: Documentation clearly explains the no-op behavior.
The doc comment accurately describes that this method always returns 0 because Masternode vote transitions don't support user fee increases. The implementation matches the documentation.
Optional: Consider mentioning API compatibility for consistency
The setter's documentation mentions "API compatibility" explicitly. For consistency, you could optionally expand the getter's doc comment:
-/// Masternode vote transitions do not support user fee increase; always returns 0.+/// Masternode vote transitions do not support user fee increase; always returns 0.+/// This method is kept for API compatibility.
This is purely a style suggestion for consistency between getter and setter documentation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`
around lines 226 - 230, The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`:
- Around line 226-230: The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9cb0b033-dd57-4093-8df7-9a87908d0211
📥 Commits
Reviewing files that changed from the base of the PR and between c3e0a83 and 377ed8a.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
@thepastaclaw
docs(wasm-dpp): add API compatibility note to getter doc comment
0fc35b2
Address CodeRabbit nitpick: mention API compatibility in
get_user_fee_increase doc comment for consistency with the setter.
@QuantumExplorer
QuantumExplorer
marked this pull request as ready for review
March 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
self-requested a review
as a code ownerMarch 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
merged commit 72384ab
into
dashpay:v3.1-devMar 12, 2026

23 of 28 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@QuantumExplorerQuantumExplorerQuantumExplorer approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thepastaclaw@QuantumExplorer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs(wasm-dpp): document no-op user fee increase methods on vote transition by thepastaclaw · Pull Request #3209 · dashpay/platform · GitHub
Skip to content
docs(wasm-dpp): document no-op user fee increase methods on vote transition - #3209
Merged
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Mar 12, 2026
Merged
docs(wasm-dpp): document no-op user fee increase methods on vote transition#3209
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Conversation
@thepastaclaw
@thepastaclawthepastaclaw
commented
Mar 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add doc comments to the no-op get_user_fee_increase / set_user_fee_increase methods on MasternodeVoteTransitionWasm, explaining they exist for API compatibility and are intentionally no-ops.
This addresses a CodeRabbit nitpick from #3183.
Validation
  • cargo check -p wasm-dpp — compiles clean.
  • Doc-only change, no behavior change.
Summary by CodeRabbit
  • New Features
    • Exposed getter and setter for Masternode vote user fee increase in the WASM API; getter returns 0 and setter is a no-op.
  • Documentation
    • Clarified that user fee increases are not supported for Masternode vote transitions and that the exposed methods are API-compatible stubs with no effect.
@thepastaclaw
docs(wasm-dpp): document no-op user fee increase methods on vote tran…
377ed8a
…sition
Addresses CodeRabbit nitpick on dashpay#3183: adds doc comments
to the getter and setter for user_fee_increase on MasternodeVoteTransition
explaining that these methods are intentional no-ops kept for API compatibility.
@thepastaclaw
thepastaclaw
commented
Mar 6, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@coderabbitai review
@github-actionsgithub-actionsBot
added this to the v3.1.0 milestone
Mar 6, 2026
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: de855f5e-5c9d-454c-beb6-ea25fd43932f
📥 Commits
Reviewing files that changed from the base of the PR and between 377ed8a and 0fc35b2.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
📝 Walkthrough
Walkthrough
Added two wasm-exported methods to MasternodeVoteTransitionWasm: getUserFeeIncrease (returns 0) and setUserFeeIncrease (no-op). Methods are API-compatible stubs; no internal state or other logic was changed.
Changes
Cohort / File(s)Summary
Masternode vote transition
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs		Added #[wasm_bindgen] accessors: getUserFeeIncrease (fn get_user_fee_increase(&self) -> u16) returning 0, and setUserFeeIncrease (fn set_user_fee_increase(&mut self, _user_fee_increase: u16)) as a no-op. No other logic modified.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Poem
🐰 I hop to the code with a cheerful squeak,

Two tiny stubs added, humble and meek,

One returns zero, the other sits still,

Masternode votes unchanged, calm on the hill,

A rabbit's small note for a change soft and meek.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding documentation to no-op user fee increase methods on the Masternode vote transition in wasm-dpp.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs (1)
226-230: Documentation clearly explains the no-op behavior.
The doc comment accurately describes that this method always returns 0 because Masternode vote transitions don't support user fee increases. The implementation matches the documentation.
Optional: Consider mentioning API compatibility for consistency
The setter's documentation mentions "API compatibility" explicitly. For consistency, you could optionally expand the getter's doc comment:
-/// Masternode vote transitions do not support user fee increase; always returns 0.+/// Masternode vote transitions do not support user fee increase; always returns 0.+/// This method is kept for API compatibility.
This is purely a style suggestion for consistency between getter and setter documentation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`
around lines 226 - 230, The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`:
- Around line 226-230: The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9cb0b033-dd57-4093-8df7-9a87908d0211
📥 Commits
Reviewing files that changed from the base of the PR and between c3e0a83 and 377ed8a.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
@thepastaclaw
docs(wasm-dpp): add API compatibility note to getter doc comment
0fc35b2
Address CodeRabbit nitpick: mention API compatibility in
get_user_fee_increase doc comment for consistency with the setter.
@QuantumExplorer
QuantumExplorer
marked this pull request as ready for review
March 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
self-requested a review
as a code ownerMarch 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
merged commit 72384ab
into
dashpay:v3.1-devMar 12, 2026

23 of 28 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@QuantumExplorerQuantumExplorerQuantumExplorer approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thepastaclaw@QuantumExplorer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
docs(wasm-dpp): document no-op user fee increase methods on vote transition by thepastaclaw · Pull Request #3209 · dashpay/platform · GitHub
Skip to content
docs(wasm-dpp): document no-op user fee increase methods on vote transition - #3209
Merged
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Mar 12, 2026
Merged
docs(wasm-dpp): document no-op user fee increase methods on vote transition#3209
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Conversation
@thepastaclaw
@thepastaclawthepastaclaw
commented
Mar 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add doc comments to the no-op get_user_fee_increase / set_user_fee_increase methods on MasternodeVoteTransitionWasm, explaining they exist for API compatibility and are intentionally no-ops.
This addresses a CodeRabbit nitpick from #3183.
Validation
  • cargo check -p wasm-dpp — compiles clean.
  • Doc-only change, no behavior change.
Summary by CodeRabbit
  • New Features
    • Exposed getter and setter for Masternode vote user fee increase in the WASM API; getter returns 0 and setter is a no-op.
  • Documentation
    • Clarified that user fee increases are not supported for Masternode vote transitions and that the exposed methods are API-compatible stubs with no effect.
@thepastaclaw
docs(wasm-dpp): document no-op user fee increase methods on vote tran…
377ed8a
…sition
Addresses CodeRabbit nitpick on dashpay#3183: adds doc comments
to the getter and setter for user_fee_increase on MasternodeVoteTransition
explaining that these methods are intentional no-ops kept for API compatibility.
@thepastaclaw
thepastaclaw
commented
Mar 6, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@coderabbitai review
@github-actionsgithub-actionsBot
added this to the v3.1.0 milestone
Mar 6, 2026
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: de855f5e-5c9d-454c-beb6-ea25fd43932f
📥 Commits
Reviewing files that changed from the base of the PR and between 377ed8a and 0fc35b2.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
📝 Walkthrough
Walkthrough
Added two wasm-exported methods to MasternodeVoteTransitionWasm: getUserFeeIncrease (returns 0) and setUserFeeIncrease (no-op). Methods are API-compatible stubs; no internal state or other logic was changed.
Changes
Cohort / File(s)Summary
Masternode vote transition
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs		Added #[wasm_bindgen] accessors: getUserFeeIncrease (fn get_user_fee_increase(&self) -> u16) returning 0, and setUserFeeIncrease (fn set_user_fee_increase(&mut self, _user_fee_increase: u16)) as a no-op. No other logic modified.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Poem
🐰 I hop to the code with a cheerful squeak,

Two tiny stubs added, humble and meek,

One returns zero, the other sits still,

Masternode votes unchanged, calm on the hill,

A rabbit's small note for a change soft and meek.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding documentation to no-op user fee increase methods on the Masternode vote transition in wasm-dpp.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs (1)
226-230: Documentation clearly explains the no-op behavior.
The doc comment accurately describes that this method always returns 0 because Masternode vote transitions don't support user fee increases. The implementation matches the documentation.
Optional: Consider mentioning API compatibility for consistency
The setter's documentation mentions "API compatibility" explicitly. For consistency, you could optionally expand the getter's doc comment:
-/// Masternode vote transitions do not support user fee increase; always returns 0.+/// Masternode vote transitions do not support user fee increase; always returns 0.+/// This method is kept for API compatibility.
This is purely a style suggestion for consistency between getter and setter documentation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`
around lines 226 - 230, The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`:
- Around line 226-230: The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9cb0b033-dd57-4093-8df7-9a87908d0211
📥 Commits
Reviewing files that changed from the base of the PR and between c3e0a83 and 377ed8a.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
@thepastaclaw
docs(wasm-dpp): add API compatibility note to getter doc comment
0fc35b2
Address CodeRabbit nitpick: mention API compatibility in
get_user_fee_increase doc comment for consistency with the setter.
@QuantumExplorer
QuantumExplorer
marked this pull request as ready for review
March 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
self-requested a review
as a code ownerMarch 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
merged commit 72384ab
into
dashpay:v3.1-devMar 12, 2026

23 of 28 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@QuantumExplorerQuantumExplorerQuantumExplorer approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thepastaclaw@QuantumExplorer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs(wasm-dpp): document no-op user fee increase methods on vote transition by thepastaclaw · Pull Request #3209 · dashpay/platform · GitHub
Skip to content
docs(wasm-dpp): document no-op user fee increase methods on vote transition - #3209
Merged
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Mar 12, 2026
Merged
docs(wasm-dpp): document no-op user fee increase methods on vote transition#3209
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Conversation
@thepastaclaw
@thepastaclawthepastaclaw
commented
Mar 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add doc comments to the no-op get_user_fee_increase / set_user_fee_increase methods on MasternodeVoteTransitionWasm, explaining they exist for API compatibility and are intentionally no-ops.
This addresses a CodeRabbit nitpick from #3183.
Validation
  • cargo check -p wasm-dpp — compiles clean.
  • Doc-only change, no behavior change.
Summary by CodeRabbit
  • New Features
    • Exposed getter and setter for Masternode vote user fee increase in the WASM API; getter returns 0 and setter is a no-op.
  • Documentation
    • Clarified that user fee increases are not supported for Masternode vote transitions and that the exposed methods are API-compatible stubs with no effect.
@thepastaclaw
docs(wasm-dpp): document no-op user fee increase methods on vote tran…
377ed8a
…sition
Addresses CodeRabbit nitpick on dashpay#3183: adds doc comments
to the getter and setter for user_fee_increase on MasternodeVoteTransition
explaining that these methods are intentional no-ops kept for API compatibility.
@thepastaclaw
thepastaclaw
commented
Mar 6, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@coderabbitai review
@github-actionsgithub-actionsBot
added this to the v3.1.0 milestone
Mar 6, 2026
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: de855f5e-5c9d-454c-beb6-ea25fd43932f
📥 Commits
Reviewing files that changed from the base of the PR and between 377ed8a and 0fc35b2.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
📝 Walkthrough
Walkthrough
Added two wasm-exported methods to MasternodeVoteTransitionWasm: getUserFeeIncrease (returns 0) and setUserFeeIncrease (no-op). Methods are API-compatible stubs; no internal state or other logic was changed.
Changes
Cohort / File(s)Summary
Masternode vote transition
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs		Added #[wasm_bindgen] accessors: getUserFeeIncrease (fn get_user_fee_increase(&self) -> u16) returning 0, and setUserFeeIncrease (fn set_user_fee_increase(&mut self, _user_fee_increase: u16)) as a no-op. No other logic modified.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Poem
🐰 I hop to the code with a cheerful squeak,

Two tiny stubs added, humble and meek,

One returns zero, the other sits still,

Masternode votes unchanged, calm on the hill,

A rabbit's small note for a change soft and meek.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding documentation to no-op user fee increase methods on the Masternode vote transition in wasm-dpp.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs (1)
226-230: Documentation clearly explains the no-op behavior.
The doc comment accurately describes that this method always returns 0 because Masternode vote transitions don't support user fee increases. The implementation matches the documentation.
Optional: Consider mentioning API compatibility for consistency
The setter's documentation mentions "API compatibility" explicitly. For consistency, you could optionally expand the getter's doc comment:
-/// Masternode vote transitions do not support user fee increase; always returns 0.+/// Masternode vote transitions do not support user fee increase; always returns 0.+/// This method is kept for API compatibility.
This is purely a style suggestion for consistency between getter and setter documentation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`
around lines 226 - 230, The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`:
- Around line 226-230: The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9cb0b033-dd57-4093-8df7-9a87908d0211
📥 Commits
Reviewing files that changed from the base of the PR and between c3e0a83 and 377ed8a.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
@thepastaclaw
docs(wasm-dpp): add API compatibility note to getter doc comment
0fc35b2
Address CodeRabbit nitpick: mention API compatibility in
get_user_fee_increase doc comment for consistency with the setter.
@QuantumExplorer
QuantumExplorer
marked this pull request as ready for review
March 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
self-requested a review
as a code ownerMarch 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
merged commit 72384ab
into
dashpay:v3.1-devMar 12, 2026

23 of 28 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@QuantumExplorerQuantumExplorerQuantumExplorer approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thepastaclaw@QuantumExplorer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs(wasm-dpp): document no-op user fee increase methods on vote transition by thepastaclaw · Pull Request #3209 · dashpay/platform · GitHub
Skip to content
docs(wasm-dpp): document no-op user fee increase methods on vote transition - #3209
Merged
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Mar 12, 2026
Merged
docs(wasm-dpp): document no-op user fee increase methods on vote transition#3209
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Conversation
@thepastaclaw
@thepastaclawthepastaclaw
commented
Mar 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add doc comments to the no-op get_user_fee_increase / set_user_fee_increase methods on MasternodeVoteTransitionWasm, explaining they exist for API compatibility and are intentionally no-ops.
This addresses a CodeRabbit nitpick from #3183.
Validation
  • cargo check -p wasm-dpp — compiles clean.
  • Doc-only change, no behavior change.
Summary by CodeRabbit
  • New Features
    • Exposed getter and setter for Masternode vote user fee increase in the WASM API; getter returns 0 and setter is a no-op.
  • Documentation
    • Clarified that user fee increases are not supported for Masternode vote transitions and that the exposed methods are API-compatible stubs with no effect.
@thepastaclaw
docs(wasm-dpp): document no-op user fee increase methods on vote tran…
377ed8a
…sition
Addresses CodeRabbit nitpick on dashpay#3183: adds doc comments
to the getter and setter for user_fee_increase on MasternodeVoteTransition
explaining that these methods are intentional no-ops kept for API compatibility.
@thepastaclaw
thepastaclaw
commented
Mar 6, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@coderabbitai review
@github-actionsgithub-actionsBot
added this to the v3.1.0 milestone
Mar 6, 2026
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: de855f5e-5c9d-454c-beb6-ea25fd43932f
📥 Commits
Reviewing files that changed from the base of the PR and between 377ed8a and 0fc35b2.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
📝 Walkthrough
Walkthrough
Added two wasm-exported methods to MasternodeVoteTransitionWasm: getUserFeeIncrease (returns 0) and setUserFeeIncrease (no-op). Methods are API-compatible stubs; no internal state or other logic was changed.
Changes
Cohort / File(s)Summary
Masternode vote transition
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs		Added #[wasm_bindgen] accessors: getUserFeeIncrease (fn get_user_fee_increase(&self) -> u16) returning 0, and setUserFeeIncrease (fn set_user_fee_increase(&mut self, _user_fee_increase: u16)) as a no-op. No other logic modified.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Poem
🐰 I hop to the code with a cheerful squeak,

Two tiny stubs added, humble and meek,

One returns zero, the other sits still,

Masternode votes unchanged, calm on the hill,

A rabbit's small note for a change soft and meek.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding documentation to no-op user fee increase methods on the Masternode vote transition in wasm-dpp.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs (1)
226-230: Documentation clearly explains the no-op behavior.
The doc comment accurately describes that this method always returns 0 because Masternode vote transitions don't support user fee increases. The implementation matches the documentation.
Optional: Consider mentioning API compatibility for consistency
The setter's documentation mentions "API compatibility" explicitly. For consistency, you could optionally expand the getter's doc comment:
-/// Masternode vote transitions do not support user fee increase; always returns 0.+/// Masternode vote transitions do not support user fee increase; always returns 0.+/// This method is kept for API compatibility.
This is purely a style suggestion for consistency between getter and setter documentation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`
around lines 226 - 230, The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`:
- Around line 226-230: The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9cb0b033-dd57-4093-8df7-9a87908d0211
📥 Commits
Reviewing files that changed from the base of the PR and between c3e0a83 and 377ed8a.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
@thepastaclaw
docs(wasm-dpp): add API compatibility note to getter doc comment
0fc35b2
Address CodeRabbit nitpick: mention API compatibility in
get_user_fee_increase doc comment for consistency with the setter.
@QuantumExplorer
QuantumExplorer
marked this pull request as ready for review
March 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
self-requested a review
as a code ownerMarch 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
merged commit 72384ab
into
dashpay:v3.1-devMar 12, 2026

23 of 28 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@QuantumExplorerQuantumExplorerQuantumExplorer approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thepastaclaw@QuantumExplorer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
docs(wasm-dpp): document no-op user fee increase methods on vote transition by thepastaclaw · Pull Request #3209 · dashpay/platform · GitHub
Skip to content
docs(wasm-dpp): document no-op user fee increase methods on vote transition - #3209
Merged
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Mar 12, 2026
Merged
docs(wasm-dpp): document no-op user fee increase methods on vote transition#3209
QuantumExplorer merged 2 commits into
dashpay:v3.1-devfrom 
thepastaclaw:docs/wasm-dpp-noop-doc-rebased
Conversation
@thepastaclaw
@thepastaclawthepastaclaw
commented
Mar 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add doc comments to the no-op get_user_fee_increase / set_user_fee_increase methods on MasternodeVoteTransitionWasm, explaining they exist for API compatibility and are intentionally no-ops.
This addresses a CodeRabbit nitpick from #3183.
Validation
  • cargo check -p wasm-dpp — compiles clean.
  • Doc-only change, no behavior change.
Summary by CodeRabbit
  • New Features
    • Exposed getter and setter for Masternode vote user fee increase in the WASM API; getter returns 0 and setter is a no-op.
  • Documentation
    • Clarified that user fee increases are not supported for Masternode vote transitions and that the exposed methods are API-compatible stubs with no effect.
@thepastaclaw
docs(wasm-dpp): document no-op user fee increase methods on vote tran…
377ed8a
…sition
Addresses CodeRabbit nitpick on dashpay#3183: adds doc comments
to the getter and setter for user_fee_increase on MasternodeVoteTransition
explaining that these methods are intentional no-ops kept for API compatibility.
@thepastaclaw
thepastaclaw
commented
Mar 6, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@coderabbitai review
@github-actionsgithub-actionsBot
added this to the v3.1.0 milestone
Mar 6, 2026
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@coderabbitai
coderabbitaiBot
commented
Mar 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: de855f5e-5c9d-454c-beb6-ea25fd43932f
📥 Commits
Reviewing files that changed from the base of the PR and between 377ed8a and 0fc35b2.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
📝 Walkthrough
Walkthrough
Added two wasm-exported methods to MasternodeVoteTransitionWasm: getUserFeeIncrease (returns 0) and setUserFeeIncrease (no-op). Methods are API-compatible stubs; no internal state or other logic was changed.
Changes
Cohort / File(s)Summary
Masternode vote transition
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs		Added #[wasm_bindgen] accessors: getUserFeeIncrease (fn get_user_fee_increase(&self) -> u16) returning 0, and setUserFeeIncrease (fn set_user_fee_increase(&mut self, _user_fee_increase: u16)) as a no-op. No other logic modified.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Poem
🐰 I hop to the code with a cheerful squeak,

Two tiny stubs added, humble and meek,

One returns zero, the other sits still,

Masternode votes unchanged, calm on the hill,

A rabbit's small note for a change soft and meek.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding documentation to no-op user fee increase methods on the Masternode vote transition in wasm-dpp.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs (1)
226-230: Documentation clearly explains the no-op behavior.
The doc comment accurately describes that this method always returns 0 because Masternode vote transitions don't support user fee increases. The implementation matches the documentation.
Optional: Consider mentioning API compatibility for consistency
The setter's documentation mentions "API compatibility" explicitly. For consistency, you could optionally expand the getter's doc comment:
-/// Masternode vote transitions do not support user fee increase; always returns 0.+/// Masternode vote transitions do not support user fee increase; always returns 0.+/// This method is kept for API compatibility.
This is purely a style suggestion for consistency between getter and setter documentation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`
around lines 226 - 230, The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs`:
- Around line 226-230: The method get_user_fee_increase currently correctly
returns 0 and matches the doc comment; to address the optional consistency
suggestion, update the doc comment above get_user_fee_increase to mirror the
setter's wording by mentioning API compatibility (e.g., "For API compatibility,
Masternode vote transitions do not support user fee increase; always returns
0."), leaving the implementation of pub fn get_user_fee_increase(&self) -> u16 {
0 } unchanged.

ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9cb0b033-dd57-4093-8df7-9a87908d0211
📥 Commits
Reviewing files that changed from the base of the PR and between c3e0a83 and 377ed8a.
📒 Files selected for processing (1)
  • packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs
@thepastaclaw
docs(wasm-dpp): add API compatibility note to getter doc comment
0fc35b2
Address CodeRabbit nitpick: mention API compatibility in
get_user_fee_increase doc comment for consistency with the setter.
@QuantumExplorer
QuantumExplorer
marked this pull request as ready for review
March 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
self-requested a review
as a code ownerMarch 12, 2026 05:08
@QuantumExplorer
QuantumExplorer
merged commit 72384ab
into
dashpay:v3.1-devMar 12, 2026

23 of 28 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@QuantumExplorerQuantumExplorerQuantumExplorer approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thepastaclaw@QuantumExplorer