Uh oh!
There was an error while loading. Please reload this page.
feat(drive): adapt to grovedb SubelementsDeletionBehavior per-op enum - #3217
Conversation
Upgrade grovedb to rev a20add8d which replaces global BatchApplyOptions fields (allow_deleting_non_empty_trees, deleting_non_empty_trees_returns_error) with per-op SubelementsDeletionBehavior on DeleteTree operations. - Use DontCheck for batch_delete_up_tree_while_empty (caller verifies emptiness) - Use DeleteChildren for delete_proposers_tree (intentionally non-empty) - Update GroveOp::DeleteTree pattern matches for new 2-field variant - Remove obsolete BatchApplyOptions fields - Update proof size assertions for latest protocol version - Update fee assertions in drive-abci tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…n-behavior' into feat/grovedb-subelements-deletion-behavior
These fee changes were from an older grovedb rev and are no longer needed with rev 2c9117cf. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…om:dashpay/platform into feat/grovedb-subelements-deletion-behavior
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Each changed assertion now notes the previous value and that the increase comes from KVValueHashFeatureTypeWithChildHash in grovedb proofs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…om:dashpay/platform into feat/grovedb-subelements-deletion-behavior
✅ gRPC Query Coverage Report |
Summary
2c9117cfwhich replaces globalBatchApplyOptionsfields (allow_deleting_non_empty_trees,deleting_non_empty_trees_returns_error) with per-opSubelementsDeletionBehaviorenum onDeleteTreeoperationsDontCheckforbatch_delete_up_tree_while_empty(caller already verifies emptiness),DeleteChildrenfordelete_proposers_tree(intentionally non-empty tree)GroveOp::DeleteTreepattern matches for the new 2-field variantBatchApplyOptionsfieldsIssue being addressed
Adapts platform to grovedb PR #634 which moves deletion behavior from a batch-global option to a per-operation setting.
Test plan
cargo check -p drivetest_initial_state_structure_proper_heights_in_latest_protocol_version— passes🤖 Generated with Claude Code