feat(sdk): source mainnet/testnet bootstrap from dash-network-seeds

[lklimek]

Issue being fixed or feature implemented

Supersedes #3530 (Copilot draft that got stuck on a sandboxed CI run). Implements #3529 — remove hardcoded DAPI bootstrap address lists from WASM SDK and FFI, centralize in dash-sdk, and source from the weekly-refreshed dash-network-seeds crate that rust-dashcore v0.42-dev ships (dashpay/rust-dashcore#678).

What was done?

Stacked on#3532 (rust-dashcore v0.42-dev bump). Once #3532 merges, this PR auto-retargets v3.1-dev with a clean 3-commit diff.

Centralization (Copilot's two commits, cherry-picked)

• SdkBuilder::new_mainnet() / new_testnet() in packages/rs-sdk/src/sdk.rs move from unimplemented!() to real constructors that return a fully wired builder with the default bootstrap address list and correct Network variant.
• packages/wasm-sdk/src/sdk.rs — dropped its own default_mainnet_addresses() / default_testnet_addresses() helpers, now calls SdkBuilder::new_mainnet() / new_testnet() directly.
• packages/rs-sdk-ffi/src/sdk.rs — dash_sdk_create_trusted()'s 54 lines of inline per-network address arrays collapse into two lines that delegate.

Seed-sourced addresses (the actual #3529 deliverable)

• Added dash-network-seeds workspace dep pinned to the same rust-dashcore rev as the other dash-* crates.
• default_address_list_for_network() in dash-sdk now iterates dash_network_seeds::evo_seeds(network) and builds https://<ip>:<platform_http_port> URIs — discarding the Core P2P port on seed.address since DAPI clients want the Platform HTTP port, which differs by network (mainnet 443, testnet 1443) and is encoded per-node in the seed file.
• No reachability / SSL filter: evo_seeds already ships only HPMNs known to the Core DMN list, and many Dash Platform nodes legitimately use self-signed certs. Let the DAPI client rotate.
• Seed files are refreshed weekly by upstream CI — we get fresh lists for free on every rust-dashcore bump (~360 mainnet Evo nodes, ~31 testnet).

Tests

• Assert the bootstrap list is non-empty and every entry uses the correct platform HTTP port (443 mainnet, 1443 testnet). Stable across weekly seed churn.
• Sanity check: both networks ship ≥10 addresses.

How Has This Been Tested?

Locally:

• cargo check -p dash-sdk -p wasm-sdk -p rs-sdk-ffi --all-targets — clean
• cargo test -p dash-sdk --lib — 117 pass, 0 fail (3 new: new_mainnet_sources_bootstrap_from_seeds, new_testnet_sources_bootstrap_from_seeds, bootstrap_counts_reasonable)
• cargo clippy -p dash-sdk --all-targets -- -D warnings — no new findings
• cargo fmt --all --check — clean

Parse timing of evo_seeds(Mainnet) (~360 entries): ~382µs. No caching added — builder construction happens ≤2 times per SDK lifetime.

Breaking Changes

None. SdkBuilder::new_mainnet() / new_testnet() were unimplemented!() placeholders before this PR — no production caller could have been reaching them. Callers of WASM SDK / FFI get a refreshed address list on every bump of rust-dashcore; same contract, better data.

Follow-up (separate issue, not this PR): packages/js-dapi-client/lib/networkConfigs.js still hardcodes a single testnet seed. JS SDKs can't consume Rust constants without WASM glue or codegen; left as is and deserves its own ticket.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any — none
• I have made corresponding changes to the documentation if needed — rustdoc on the new helpers explains the sourcing

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Credit: @copilot drafted the centralization and delegation layer in #3530. Final commit replaces the baked-in IPs with the dynamic seed query.

_{🤖 Co-authored by Claudius the Magnificent AI Agent}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e6594636-2a85-4e8c-8a00-6a273557e02d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/sdk-address-list

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[thepastaclaw]

✅ Review complete (commit 1f37eaf)

[Copilot]

Pull request overview

Centralizes mainnet/testnet SDK bootstrapping and replaces hardcoded DAPI gateway lists with seed-derived addresses sourced from the dash-network-seeds crate.

Changes:

• Implement SdkBuilder::new_mainnet() / new_testnet() to construct builders with seed-sourced default bootstrap lists.
• Update WASM SDK and FFI layers to delegate mainnet/testnet construction to the shared SdkBuilder constructors.
• Add unit tests asserting non-empty bootstrap lists and correct per-network Platform HTTP ports.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/rs-sdk/src/sdk.rs	Adds seed-sourced default address list builder, implements mainnet/testnet constructors, and adds tests for non-empty/port correctness.
packages/wasm-sdk/src/sdk.rs	Removes duplicated hardcoded gateway lists; uses shared SdkBuilder::new_mainnet() / new_testnet().
packages/rs-sdk-ffi/src/sdk.rs	Collapses inline per-network address arrays into calls to shared SdkBuilder constructors.
packages/rs-sdk/Cargo.toml	Adds dash-network-seeds dependency to the SDK crate.
Cargo.toml	Adds dash-network-seeds to workspace dependencies pinned to the rust-dashcore rev.
Cargo.lock	Records the new dependency in the lockfile.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[thepastaclaw]

Code Review

Verified all three Claude FFI-engineer findings against the actual code. Two are purely speculative (private function with intentional documented panic; deterministic compile-time seed parsing covered by build-time tests). One is a real but latent defensive concern about IPv6 formatting. Codex security review found no issues.

Reviewed commit: 1f37eaf

💬 1 nitpick(s)

[QuantumExplorer]

much cleaner