test(drive-abci): add token supply edge-case coverage

[thephez]

Issue being fixed or feature implemented

Token supply handling lacked coverage for several edge cases (exact max_supply boundary, burning below base_supply, burning to zero, destroy-frozen-funds supply accounting, zero/i64::MAXbase_supply, etc.). While adding that coverage, two real gaps surfaced:

1. base_supply > max_supply is accepted at contract creation. There is no creation-time guard comparing the two (only base_supply > i64::MAX is rejected). The token is born already over its cap, base_supply is immutable, so every subsequent mint is permanently blocked by TokenMintPastMaxSupplyError. Tracked in base_supply > max_supply is accepted at token contract creation, permanently blocking mints #3850
2. Minting past i64::MAX on a token with max_supply == None returns an InternalError instead of a graceful consensus error. The mint validation's supply check is wrapped in if let Some(max_supply) = ..., so the uncapped case has no validation-layer guard and is only caught by the low-level Drive checked_add. Tracked in Minting past i64::MAX on an uncapped token returns InternalError instead of a consensus error #3848.

This PR is tests only — no production behavior changes. The two gaps are documented (see below) for follow-up fixes.

What was done?

Added ABCI state-transition tests under .../batch/tests/token/:

• Mint: mint to exactly max_supply (succeeds), one over (fails, full TokenMintPastMaxSupplyError payload asserted), unbounded mint when max_supply == None, mint from zero base_supply, mint from zero to exact max.
• Burn: burn below base_supply (allowed by design), burn entire supply to zero then mint again.
• Destroy frozen funds: total supply reduced to zero, and decremented by exactly the destroyed amount (existing tests never asserted total supply).
• Config update: set max_supply equal to current supply (boundary, succeeds), raise max_supply then mint into the new headroom.

Documenting the two gaps:

• test_data_contract_creation_with_base_supply_over_max_supply_should_cause_error (in data_contract_create) — runs a real DataContractCreateTransition and asserts the intended rejection. #[ignore]d because it fails on current code; it is the regression target for adding the creation-time guard.
• test_token_mint_with_max_i64_base_supply_then_overflow_returns_internal_error_without_mutating_supply
  — a characterization test pinning the current InternalError-without-mutation behavior (gap feat: enable mainnet for dashmate #2). Named to make clear it is not the desired long-term API; it should break (intentionally) when the validation guard is added.

How Has This Been Tested?

• cargo test -p drive-abci for the token and data_contract_create::tests::tokens modules: all executable tests pass (200 + 21), with exactly one #[ignore]d test (the creation-guard regression target).
• Verified the ignored test fails as intended under --ignored (proving the gap is real and the assertion non-vacuous).
• cargo fmt -p drive-abci clean.

Breaking Changes

None — tests only.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Tests
  • Added token burn coverage for burns below base supply and for burning all supply then minting again.
  • Added token configuration update tests for updating max supply to current supply and raising the cap before minting.
  • Added token destroy-frozen-funds tests covering zeroing total supply and decrementing total supply while validating account state.
  • Expanded token minting boundary tests for max supply behavior, max_supply = None, base_supply edge cases, and overflow handling.
  • Added an ignored regression test for data contract creation with inconsistent base/max supply.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9fa34487-c6f4-4bc6-bb45-933851357bde

📥 Commits

Reviewing files that changed from the base of the PR and between 6354960 and 80f5617.

📒 Files selected for processing (1)

• packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/data_contract_create/mod.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/data_contract_create/mod.rs

---

📝 Walkthrough

Walkthrough

Adds multiple new token tests: minting boundary cases, burning invariants, config-update scenarios, frozen-funds destruction tests, and an ignored data-contract creation regression. No production code changes.

Changes

Token Operations Test Coverage

Layer / File(s)	Summary
Token minting boundary conditions packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/tests/token/mint/mod.rs	Six tests covering mint to exact max_supply, one-over-max rejection (TokenMintPastMaxSupplyError), unbounded minting when max_supply == None, base_supply == 0 initialization and minting, mint-to-max-from-zero then one-over rejection, and overflow characterization when base_supply == i64::MAX.
Token burning edge cases packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/tests/token/burn/mod.rs	Two tests: burning below original base_supply updates both identity balance and total supply (can drop below base), and burning entire supply leaves total supply as Some(0) so subsequent minting restores supply and balances.
Token configuration updates packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/tests/token/config_update/mod.rs	Two tests: setting max_supply equal to current total supply succeeds and persists, and raising max_supply after hitting cap enables a subsequent mint into the new headroom (while a prior mint at cap fails).
Frozen funds destruction packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/tests/token/destroy_frozen_funds/mod.rs	Imports expanded and two tests added: destroying frozen funds to zero total supply and destroying frozen funds that decrement total supply; adds private process_and_commit_success test helper.
Data contract creation validation packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/data_contract_create/mod.rs	Ignored regression test added that constructs a contract with base_supply > max_supply, processes the creation transition expecting consensus rejection, commits, and verifies the token was not created (fetch_token_total_supply == None).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• Minting past i64::MAX on an uncapped token returns InternalError instead of a consensus error #3848: Tests exercise the same minting-overflow and boundary behaviors described in the issue.
• base_supply > max_supply is accepted at token contract creation, permanently blocking mints #3850: The ignored creation regression directly targets the base_supply > max_supply creation validation discussed in the issue.

Suggested reviewers

• thepastaclaw
• QuantumExplorer

Poem

🐰
I hopped through tests both big and small,
Burned and minted, watched totals fall,
Froze some funds, then swept them clean,
Edge cases checked in every scene —
A rabbit cheers for coverage all!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: adding test coverage for token supply edge cases.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/token-supply-edge-cases

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[thepastaclaw]

✅ Final review complete — no blockers (commit 4496d96)

[codecov]

Codecov Report

❌ Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.50%. Comparing base (552abfc) to head (66404a7).
⚠️ Report is 18 commits behind head on v4.1-dev.

Files with missing lines	Patch %	Lines
...tion/state_transitions/data_contract_create/mod.rs	0.00%	70 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@ Coverage Diff @@## v4.1-dev #3849 +/- ##
=============================================
+ Coverage 65.42% 87.50% +22.08% 
=============================================
Files 26 2667 +2641 Lines 2707 337434 +334727 =============================================
+ Hits 1771 295285 +293514 - Misses 936 42149 +41213 

Components	Coverage Δ
dpp	88.50% <97.80%> (∅)
drive	86.25% <96.00%> (∅)
drive-abci	89.51% <4.81%> (∅)
sdk	∅ <ø> (∅)
dapi-client	∅ <ø> (∅)
platform-version	∅ <ø> (∅)
platform-value	92.88% <94.67%> (∅)
platform-wallet	∅ <ø> (∅)
drive-proof-verifier	49.79% <ø> (∅)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[thepastaclaw]

Code Review

Tests-only PR adding well-targeted token supply edge-case coverage and two characterization tests for documented gaps (#3848, #3850). Verified the new tests against the production code: assertions match current behavior and the helpers mirror the established patterns. One in-scope suggestion: the ignored regression test for base_supply > max_supply should narrow its assertion to UnpaidConsensusError(BasicError(_)) so it actually enforces the intended validation stage when the fix lands.

🟡 1 suggestion(s)

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/data_contract_create/mod.rs`:
- [SUGGESTION] packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/data_contract_create/mod.rs:1764-1768: Ignored regression test accepts too broad a class of errors
`test_data_contract_creation_with_base_supply_over_max_supply_should_cause_error` is the regression target for a future creation-time guard, but the assertion accepts either `UnpaidConsensusError` or any `PaidConsensusError`. A `base_supply > max_supply` violation is a contract-shape problem that the future guard should reject at basic structure validation (alongside the existing `base_supply > i64::MAX` check noted in the comment), which produces `UnpaidConsensusError(BasicError(_))`. As written, this test would still pass even if the fix only rejected the contract later in the paid execution path, defeating the regression intent. The `total_supply == None` assertion below proves the token was not created but not that rejection happened in the right stage.

[thepastaclaw]

Code Review

Tests-only PR adding token supply edge-case coverage in drive-abci. The single prior finding from 8c1fedf (overly broad assertion in the ignored regression test) is FIXED at 6354960 — the assertion now requires UnpaidConsensusError(ConsensusError::BasicError(_)), locking the future fix to basic-structure validation. No new in-scope issues; documented production gaps (#3848, #3850) are explicitly tracked as out-of-scope follow-ups.