Uh oh!
There was an error while loading. Please reload this page.
build(dashmate): update Tenderdash image to v1.6.0 - #3940
Conversation
Bump the default Tenderdash docker image in the base config from dashpay/tenderdash:1.6-dev.1 to dashpay/tenderdash:1.6.0-dev.1. Add a config migration entry keyed to 4.0.0-rc.2 so existing user configs pick up the new image on `dashmate update`, not only fresh installs. The entry pulls the image from the base config, matching the established pattern for prior Tenderdash image bumps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>
Bump the default Tenderdash docker image in the base config to dashpay/tenderdash:1.6.0-dev.2. This pin is intentionally ahead of Docker Hub publication: the dev.2 image is not yet pushed. A one-line TODO on the image line tracks the external dependency and should be removed once the image is published. The config migration entry keyed to 4.0.0-rc.2 pulls the image DRY from the base config, so existing user configs pick up the new value on `dashmate update` without a separate edit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>
…n Docker Hub dashpay/tenderdash:1.6.0-dev.2 is now published on Docker Hub (multi-arch amd64/arm64), so the temporary pending-publish TODO above the image line no longer applies and is removed. The pinned image is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…nderdash-1.6.0-dev.2 # Conflicts: # packages/dashmate/configs/getConfigFileMigrationsFactory.js
The 1.6.0 release is now published on Docker Hub (multi-arch amd64/arm64), so replace the 1.6.0-dev.2 pre-release placeholder with the final 1.6.0 tag. The 4.0.0-rc.3 config migration pulls the image DRY from the base config, so existing user configs upgrade to 1.6.0 automatically on `dashmate update`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Review complete (commit 7a7b212) |
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
The Tenderdash default image bump itself matches the PR goal and points existing defaults at the final 1.6.0 tag. The migration is too broad: it rewrites every persisted Tenderdash image, including documented operator customizations, instead of only upgrading configs still on Dashmate-shipped prerelease tags.
🟡 1 suggestion(s)
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `packages/dashmate/configs/getConfigFileMigrationsFactory.js`:
- [SUGGESTION] packages/dashmate/configs/getConfigFileMigrationsFactory.js:1526-1531: Preserve customized Tenderdash images during migration
This migration unconditionally replaces `platform.drive.tenderdash.docker.image` for every config. That upgrades stale defaults, but it also discards explicit operator settings made through the documented Tenderdash image option, such as a private patched image or a local test image. The migration only needs to move configs still using Dashmate-shipped Tenderdash 1.6 prerelease tags to the final base default, matching the preservation approach used by the nearby Envoy image migration.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## v3.1-dev #3940 +/- ##
==========================================
Coverage 87.17% 87.18% ==========================================
Files 2629 2632 +3 Lines 327221 327563 +342 ==========================================
+ Hits 285265 285592 +327 - Misses 41956 41971 +15
🚀 New features to boost your workflow:
|
Why this PR exists
1.6-dev.1). The Tenderdash 1.6.0 line is now final and published on Docker Hub.What was done
packages/dashmate/configs/defaults/getBaseConfigFactory.jsto the finaldashpay/tenderdash:1.6.0.4.0.0-rc.3config migration inpackages/dashmate/configs/getConfigFileMigrationsFactory.jsso existing user configs upgrade ondashmate update. The image is pulled DRY from the base config, so the migration tracks whatever the base config pins.4.0.0-rc.3(the next unreleased version), not the already-released4.0.0-rc.2: the migration runner skipsfromVersion === toVersion, so a key equal to an operator's current version never fires. Backfill runs once the package bumps to rc.3.4.0.0-rc.3migration already carried the rate-limiterresponseHeadersbackfill from base; both backfills now share that single migration (a duplicate object key would silently overwrite).Testing
dashpay/tenderdash:1.6.0is published on Docker Hub (multi-arch amd64/arm64, pushed 2026-06-26).yarn workspace dashmate lint→ 0 errors.node --checkpasses on both modified files.Breaking Changes
Checklist:
For repository code-owners and collaborators only
🤖 Co-authored by Claudius the Magnificent AI Agent