Uh oh!
There was an error while loading. Please reload this page.
fix: bump rust-dashcore to c88264e7 for Android SPV file-lock fix - #4014
Conversation
Move the shared rust-dashcore pin from afcff156 to c88264e7 (dev, a clean 4-commit fast-forward) to pick up dash-spv #841, which makes the advisory lock-file guard degrade gracefully when std file locking is unsupported — the case on target_os=android, where Core/SPV otherwise fails to start ("try_lock() not supported"). Also includes dash-spv #835 (filter-sync restart stall) and #827 (internal peer-config field rename; not referenced here). Cargo.lock updates only the rust-dashcore-sourced crates. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates the git revision pin for eight rust-dashcore workspace dependencies (dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, dashcore-rpc) in Cargo.toml to a newer commit. ChangesDependency Revision Update
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Review complete (commit 7e71dda) |
There was a problem hiding this comment.
Code Review
Source: reviewers = Claude Opus and Codex gpt-5.5 for general/ffi-engineer; verifier = Claude Opus; specialists = ffi-engineer.
Pure dependency-pin bump of workspace rust-dashcore crates from afcff156 to c88264e7. Both agents independently verified the four upstream commits are non-consensus SPV/wallet changes with no FFI or API surface impact on this repo. No findings to flag.
Uh oh!
There was an error while loading. Please reload this page.
Issue being fixed or feature implemented
Bumps the
rust-dashcorepin so the workspace picks up the Android SPV file‑lock fix and two otherdash-spvfixes that landed ondevsince the current pin.The headline motivation is dashpay/rust-dashcore#840: on
target_os = "android",std::fs::File::try_lock()is a compile‑timeUnsupportedstub (Android isn't in std'sflockcfg list), sodash-spv's lock‑file guard failed fatally and Core/SPV could never start in the Android SDK. rust-dashcore #841 makes the lock degrade gracefully; this bump brings it into the platform. Without it, the KotlinExampleApp (#3999) Core layer is dead on device.What was done?
Updated the single shared
rust-dashcorerevin the workspace[workspace.dependencies](all 8 crates:dashcore,dash-spv,key-wallet,key-wallet-ffi,key-wallet-manager,dash-network,dash-network-seeds,dashcore-rpc) plus the matchingCargo.lockentries:devis a clean fast‑forward (4 commits, 0 behind) over the old pin. The four commits pulled in:fix(dash-spv): degrade gracefully when advisory file locking is unsupported (Android)— the fix this PR is for.fix(dash-spv): avoid filter sync getting stuck on the first new block after a restart.fix(dash-spv): replaced TARGET_PEERS with already existing max_peers config field— internal todash-spv; the platform references neithertarget_peersnormax_peers, so no call‑site changes were needed.ci:automation fix (no code impact).Cargo.lockmoved only the rust-dashcore‑sourced crates to the new rev; 92 other dependencies are unchanged.How Has This Been Tested?
cargo check -p platform-wallet(the primarydash-spvconsumer) against the new rev — green; it re-compileddash-spv/key-wallet/dpp/drive/dash-sdk/platform-walletagainstc88264e7with no errors (Finished dev profile … in 1m00s). Confirms no API drift from the 4 upstream commits.On the underlying fix: the Android failure this unblocks was reproduced and root‑caused on an API‑35 arm64 emulator against the old pin — starting Core sync threw
SPV error: Write failed: Failed to acquire lock: try_lock() not supported, which is exactly the path rust-dashcore#841 makes non‑fatal. Re‑verifying Core SPV start on device with the new pin (rebuild thers-unified-sdk-jni.so) is the natural follow‑up.Breaking Changes
None.
dash-spv/key-walletare the client/SPV + wallet layer, not consensus code — this is not a consensus‑breaking change. No public API changes on the platform side (thedash-spvdeltas are internal fixes; #827's config‑field rename is not referenced by this repo).Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code
Summary by CodeRabbit