Uh oh!
There was an error while loading. Please reload this page.
chore(platform-wallet): merge platform-wallet-rehydration (PR #3692) into dash-evo-tool - #4039
Conversation
… branch Points the 8 rust-dashcore workspace deps at dashpay/rust-dashcore#850 (feat/key-wallet-asset-lock-explicit-utxo-override @ d42081e7), which adds an explicit-UTXO-override escape hatch for asset-lock funding. Updates the one build_asset_lock_with_signer call site in this branch for the new optional override parameter (passed as None — this branch doesn't use the override). TODO(pin) left in Cargo.toml: bump again once #850 merges to dev. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
PR #850 (asset-lock explicit UTXO override) and PR #851 (key-wallet out-of-order UTXO spend fix, #649) are disjoint branches off `dev`. Re-point the pin at #851's head, which this crate's watch-only rehydration work actually needs. The only call site depending on #850's API (`build_asset_lock_with_signer`'s `override_utxo` param) was passing `None` — a no-op default — so dropping the argument to match #851's 5-arg signature is a pure mechanical revert, no behavior change. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…' into merge-pr3692-into-dash-evo-tool
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
Why this PR exists
dash-evo-toolapp depends on this repo'sdash-evo-toolintegration branch, which was pinned to an older rust-dashcore rev (647fa982) than PR feat(platform-wallet): load watch-only wallet state from local storage at startup #3692's branch (feat/platform-wallet-rehydration).dash-evo-toolapp doesn't get the rust-dashcore feat(rs-dpp): migrate fees from js-dpp v0.24 #851 fix (key-wallet out-of-order UTXO spend / feat(wasm-dpp): implement asset lock proof bindings #649) that feat(platform-wallet): load watch-only wallet state from local storage at startup #3692 now depends on, nor feat(platform-wallet): load watch-only wallet state from local storage at startup #3692's own watch-only rehydration work.dash-evo-toolbranch up to date with PR feat(platform-wallet): load watch-only wallet state from local storage at startup #3692 (feat(platform-wallet): load watch-only wallet state from local storage at startup #3692).What was done
Merge commit bringing
feat/platform-wallet-rehydration(PR #3692) intodash-evo-tool. Only diff beyond history reconciliation: the rust-dashcore workspace pin bump (647fa982→48a07d3f, tracking rust-dashcore#851) already present on #3692's branch. No conflicts —dash-evo-toolhad never diverged on those Cargo.toml lines.Testing
cargo check -p platform-wallet -p platform-wallet-storage -p platform-wallet-ffi— clean compile against the merged tree.ortmerge strategy; no manual resolution needed.Breaking changes
None.
Checklist
Attribution
🤖 Co-authored by Claudius the Magnificent AI Agent