Skip to content

feat: re-enable proof responses - #440

Merged
shumkov merged 32 commits into
v0.23-devfrom
proofs
Jun 29, 2022
Merged

feat: re-enable proof responses#440
shumkov merged 32 commits into
v0.23-devfrom
proofs

Conversation

@shuplenkov

@shuplenkovshuplenkov commented Jun 17, 2022•
edited
Loading

Copy link
Copy Markdown

Issue being fixed or feature implemented

To provide proofs to clients we need to re-enable prove=true param in our endpoints and make sure that these endpoints respond with proofs.

What was done?

Re-enabled proof logic in drive

How Has This Been Tested?

With tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkovshuplenkov added this to the v0.23.0 milestone Jun 17, 2022
shumkov
shumkov requested changes Jun 21, 2022
View reviewed changes
Comment threadpackages/js-drive/lib/abci/handlers/query/dataContractQueryHandlerFactory.js Outdated
shumkov
shumkov requested changes Jun 23, 2022
View reviewed changes
Comment threadpackages/js-drive/lib/document/fetchDataContractFactory.js Outdated
Comment threadpackages/js-drive/lib/document/fetchDocumentsFactory.js
shumkov
shumkov reviewed Jun 23, 2022
View reviewed changes
Comment threadpackages/js-drive/lib/abci/handlers/query/documentQueryHandlerFactory.js Outdated
shumkov
shumkov reviewed Jun 23, 2022
View reviewed changes
Comment threadpackages/js-drive/lib/dpp/DriveStateRepository.js Outdated
shumkov
shumkov reviewed Jun 23, 2022
View reviewed changes
Comment threadpackages/js-drive/test/integration/document/DocumentRepository.spec.js
@shuplenkov
shuplenkov marked this pull request as ready for review June 27, 2022 15:53
@shuplenkov
shuplenkov requested a review from shumkovJune 27, 2022 15:55
@shumkovshumkov changed the title feat: re-enable proof logicfeat: re-enable proof responsesJun 29, 2022
shumkov
shumkov approved these changes Jun 29, 2022
View reviewed changes

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shumkov
shumkov merged commit 2fcaf30 into v0.23-devJun 29, 2022
@shumkov
shumkov deleted the proofs branch June 29, 2022 09:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumkovshumkovshumkov approved these changes
@antouhouantouhouAwaiting requested review from antouhou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.23.0

Development

Successfully merging this pull request may close these issues.

2 participants

@shuplenkov@shumkov