Uh oh!
There was an error while loading. Please reload this page.
feat(dashmate): upgrade docker compose to v2 - #441
Merged
Conversation
This pull request introduces 4 alerts when merging a63acb9 into a9fd1b9 - view on LGTM.com new alerts:
|
* the new docker compose v2 throws error if services have not been run before
This reverts commit 0b1117a.
pshenmicforce-pushed
the
feat/docker-compose-v2
branch
from
June 20, 2022 06:58
a63acb9 to
16b35ffComparepshenmic
marked this pull request as draft
June 20, 2022 07:12
5 tasks
pshenmic
commented
Jun 21, 2022
ContributorAuthor
pshenmic
marked this pull request as ready for review
June 21, 2022 07:08
shumkov
previously approved these changes
Jun 21, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
shumkov
requested changes
Jun 23, 2022
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Docker has introduced new Docker Compose v2 engine few years ago, which is now bundled with Docker and does not require installing additional packages. There is a completely new and rewritten core engine in Go that also features a lot of new cool things. Along with that, older v1 docker-compose binaries will soon become deprecated. The syntax of the commands switched to
docker composeinstead ofdocker-compose, and legacy commands.Previously, you had to enable this feature to use v2. But now it is enabled out of the box on every system, and since its inconvenient to tell users to install outdated tools and we already require Docker v20.10+, we can safely migrate to new commands.
This upgrade will keep our project up to date with latest Docker features and also will remove the require of installing additional tools like docker-compose.
What was done?
How Has This Been Tested?
Locally, and via platform-test-suite on CI (test are passing)
Breaking Changes
No breaking changes from the users perspective. Any commands stayed the same, while internally it uses the new engine.
Checklist:
For repository code-owners and collaborators only