Uh oh!
There was an error while loading. Please reload this page.
chore: bump rust-dashcore pin for multilingual BIP-39 mnemonic parsing - #4455
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🕓 Ready for review — 1 ahead in queue (commit faf02a3) |
…arsing) Pin fix/mnemonic-any-language-173ffac: the cherry-pick of dashpay/rust-dashcore#980 onto 173ffac0, the rev v4.2-dev already pins. This lands the BIP-39 fix without crossing the breaking key-wallet sweep changes (rust-dashcore #961/#962/#966/#969) that #4406 adapts platform to; once #4406 bumps onto rust-dashcore dev proper, the pin rejoins dev and this branch can be deleted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2af6698 to
faf02a3CompareThe base branch was changed.
Uh oh!
There was an error while loading. Please reload this page.
…ashcore-dev-961 Two conflicts, both about the rust-dashcore pin, plus one semantic break the textual merge hid. `v4.2-dev` pinned `a97b32c6` in #4455, which turns out to be a side branch off the old `173ffac0` carrying cherry-picks of the seed refresh and the BIP-39 fix. This branch pinned `5877d15f`, on `dev`'s mainline. Neither contains the other. Resolved onto `dev`'s head `b66db390`, which is a superset of both: it carries the seed refresh (#970) and the BIP-39 fix (#980) that `v4.2-dev` wanted, plus #966 and #969 that this branch needs, plus the QRInfo masternode-sync recovery (#947). The hidden break: `v4.2-dev` added `get_wallet_blocking`, which calls `blocking_read()` on the wallets map — a method this branch removed when the map became an `ArcSwap`. Git merged the file cleanly and the build failed. The accessor now loads wait-free; its name is kept so the FFI callers that predate the change still compile.
Pins
fix/mnemonic-any-language-173ffac(a062ccb9) — the cherry-pick of dashpay/rust-dashcore#980 onto173ffac0, the exact revv4.2-devalready pins.