Uh oh!
There was an error while loading. Please reload this page.
fix(platform-wallet): re-seed shield regression fixture for the protocol 14 fee rebalance - #4489
fix(platform-wallet): re-seed shield regression fixture for the protocol 14 fee rebalance#4489QuantumExplorer wants to merge 1 commit into
Conversation
…col 14 fee rebalance The #4467 rebalance dropped the PV14 two-action minimum shielded fee to 114,140,000 credits, so the shield planner's input-0 reserve (2x the fee) fell from 325,702,400 to 228,280,000. The usable-suffix regression fixture seeded its leading address with 297,264,780 - below the old reserve but above the new one - so the address no longer stays out of the usable suffix and the test's guard assert panics on a clean checkout when run with --features shielded. Re-seed the leading address to 197,264,780 (back below the reserve) and update the guard and the derived account total. The other balances, the usable-suffix total, and the pinned capacity-error values are unchanged, preserving the regression's intent: max shieldable capacity must be reported from the usable suffix, not the total account balance. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Final review complete — no blockers (commit e8494b8) |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Codex/Sol only (Phase 2 disabled)
At exact head e8494b8, the fixture update correctly keeps the leading balance below the protocol 14 reserve while preserving the usable suffix, capacity assertions, and arithmetically correct account total. The targeted shielded-feature regression test passes, and no in-scope issues were found.
Source: reviewer backend model gpt-5.6-sol; final verifier backend model gpt-5.6-sol. Orchestration-only (not reviewer evidence): openclaw-agent/cliproxy/gpt-5.6-sol.
Validated zero-blocker Codex/Sol precheck evidence was promoted to final because Phase 2 (Sonnet/Opus) is temporarily disabled. This is Codex/Sol-only final validation, not Codex + Sonnet/Opus coverage.
Review provenance
- Codex reviewers:
gpt-5.6-sol— general (completed) - Verifier:
gpt-5.6-sol— verifier - Sonnet/Opus: not run (Phase 2 disabled — temporary Codex/Sol-only final)
- Secondary pass: disabled (
temporary_phase2_sonnet_disable)
Issue being fixed or feature implemented
wallet::platform_wallet::shield_input_selection_tests::regression_reports_max_from_usable_suffix_not_total_account_balancepanics on a clean checkout ofv4.2-devwhen run with--features shielded:This is fixture fallout from #4467: the rebalance dropped the PV14 two-action minimum shielded fee to 114,140,000 credits, so the shield planner's input-0 reserve (2× the fee,
shield_fee_reserve_credits) fell from 325,702,400 to 228,280,000. The fixture's leading address (297,264,780) was below the old reserve but is above the new one, so it no longer stays out of the usable suffix — exactly the drift the test's guard assert exists to catch.What was done?
Re-seeded the fixture as the guard message instructs: the leading address goes 297,264,780 → 197,264,780 (back below the reserve — input-0 viability is strict
> reserve, so ≤ reserve keeps it excluded), and the guard assert plus the derived account total (3,921,114,000 → 3,821,114,000) follow. The other two balances, the usable-suffix total (3,623,849,220), and the pinned capacity-error values are untouched, so the regression keeps asserting its original intent: max shieldable capacity is reported from the usable suffix, not the total account balance.How Has This Been Tested?
cargo test -p platform-wallet --lib --features shielded regression_reports_max_from_usable_suffix— passes (note: the module is gated behind theshieldedfeature, which is why default test runs never execute it)cargo test -p platform-wallet -p platform-wallet-ffi -p platform-wallet-storage --all-features— all suites passcargo fmt --all,cargo clippy --workspace --all-targets -- -D warnings,cargo check --workspace --all-features— cleanBreaking Changes
None — test-only change.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code