Uh oh!
There was an error while loading. Please reload this page.
chore: ensure consistent Rust dependencies - #658
Merged
Merged
Conversation
fominok
approved these changes
Dec 7, 2022
antouhou
approved these changes
Dec 7, 2022
QuantumExplorer added a commit
that referenced
this pull request
May 11, 2026
…logists Sweeps the new comments introduced in this PR for narrative phrases that age poorly — "PR #3623 review comment r3214794852", "Codex review finding #3", "grovedb#656/#658", "what used to be ~30-line per-mode match arms", "the prior merge-based code", "earlier drafts of the v12 endpoint", "pre-refactor behavior", etc. — and rewrites them to explain what the code does and why, without requiring the reader to have lived through the PR's history. Specific rewrites: - `rs-drive-abci/src/query/document_count_query/v0/mod.rs`: - `test_documents_count_with_in_and_prove_returns_proof` docstring drops the "PR #3623 review comment" + commit-hash narrative and states the two end-to-end guarantees the test pins (routing → PointLookupProof; dispatcher → threads order_by). - `test_documents_count_range_with_prove_and_distinct_returns_proof` drops the "earlier commits rejected this" + commit-hash phrasing and describes the dispatch path + wire-shape contract directly. - `rs-drive/src/query/drive_document_count_query/`: - `drive_dispatcher.rs`: module + impl docstrings drop "collapse what used to be ~30-line per-mode match arms" framing; describe the per-mode contract on its own terms. - `execute_point_lookup.rs`: "Codex review finding #3" → describes the dedupe invariant directly. - `execute_range_count.rs`: "cursor field used to exist but was removed before v12 shipped" → "no cursor field because single- `bytes` would be ambiguous for compound queries"; "the prior merge-based code" → "bounded by the contract author's index choice". - `tests.rs`: drops "Codex review finding #3" and "pre-refactor behavior" framings. - `rs-drive/src/drive/contract/insert/insert_contract/v0/mod.rs`: - `range_count_with_in_on_prefix_returns_per_brand_color_entries`: "cross-fork merging was dropped (originally bg of Codex…)" → explains why merging pre-limit can undercount. - `range_count_executor_accepts_starts_with_in_all_four_modes`: drops "earlier commits rejected `StartsWith`, this is the rewrite". - `aggregate_count_proof_verifies_on_compound_index_with_equal_prefix`: "grovedb#658's multi-layer envelope" → "grovedb's multi-layer aggregate-count proof envelope". - `aggregate_count_proof_counts_cars_in_parking_lots_greater_than_b`: "Real-world scenario test for grovedb#656's primitive" → "Scale test for the AggregateCountOnRange proof primitive". - `range_count_executor_returns_per_lot_counts_…`: drops "no-proof companion to grovedb#656's primitive" framing. - `distinct_count_proof_with_in_on_prefix_returns_…`: "this was the original motivation for the no-merge design, Codex finding 1" → direct explanation of why server-side merging would undercount under per-fork limits. - `rs-sdk/src/platform/documents/document_count_query.rs`: - struct docstring drops "added in PR #3623" framing. - `limit` field's pagination note drops the "cursor field existed earlier but was removed before v12 shipped" narrative. - `wasm-sdk/src/queries/document.rs`: - `getDocumentsCount` docstring drops "unified successor to the previous getDocumentsCount / getDocumentsSplitCount pair" framing. - `book/src/drive/document-count-trees.md`: - Pagination paragraph drops "existed in earlier drafts of the v12 endpoint but was removed before shipping" narrative. No behavior change, no public-API surface change. Verified clippy + fmt clean across the touched crates with `-D warnings`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
In different environments might be used different versions of dependencies since they are not locked. For example, there is no guarantee that code that works in development will work on CI. Also possible that some of the dependencies will be updated and released as Drive's docker image without even testing or auditing.
As a side effect, CI cache will be much more efficient so we should expect a speed boost in our builds.
Platform and Drive should be considered as end product:
https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries
What was done?
How Has This Been Tested?
With CI
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only