Skip to content

feat(dapi)!: use single envoy port for all connections - #752

Merged
shuplenkov merged 14 commits into
v0.24-devfrom
envoy_one_port
Jan 26, 2023
Merged

feat(dapi)!: use single envoy port for all connections#752
shuplenkov merged 14 commits into
v0.24-devfrom
envoy_one_port

Conversation

@shuplenkov

@shuplenkovshuplenkov commented Jan 24, 2023•
edited
Loading

Copy link
Copy Markdown

Issue being fixed or feature implemented

Replace two ports DAPI addresses with single port ones

What was done?

Changes envoy config and dapi client to introduce single port support

How Has This Been Tested?

With tests

Breaking Changes

Will not support double port urls

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkovshuplenkov added this to the v0.24.0 milestone Jan 24, 2023
@shuplenkovshuplenkov changed the title feat(dapi): use single envoy port for all connectionsfeat(dapi)!: use single envoy port for all connectionsJan 24, 2023
shumkov
shumkov requested changes Jan 24, 2023
View reviewed changes
Comment threadpackages/dashmate/src/commands/status/platform.js Outdated
Comment threadpackages/dashmate/src/commands/status/platform.js Outdated
Comment threadpackages/dashmate/configs/system/base.js
Comment threadpackages/js-dapi-client/lib/transport/GrpcTransport/GrpcTransport.js Outdated
Konstantin Shuplenkov added 3 commits January 24, 2023 17:08
Konstantin Shuplenkov
Merge branch 'v0.24-dev' into envoy_one_port
e9b8183
# Conflicts:
#	packages/dashmate/src/commands/status/platform.js
Konstantin Shuplenkov
WIP
7763fe7
Konstantin Shuplenkov
WIP
4dab716
shumkov
shumkov previously approved these changes Jan 24, 2023
View reviewed changes

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Konstantin Shuplenkov
Merge branch 'v0.24-dev' into envoy_one_port
6ece17f
# Conflicts:
#	packages/dashmate/src/commands/status/platform.js
Konstantin Shuplenkov added 5 commits January 25, 2023 14:20
shumkov
shumkov approved these changes Jan 26, 2023
View reviewed changes

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov
shuplenkov merged commit 896816a into v0.24-devJan 26, 2023
@shuplenkov
shuplenkov deleted the envoy_one_port branch January 26, 2023 15:32
@pshenmicpshenmic mentioned this pull request Jan 27, 2023
Merged
5 tasks
This was referenced Jun 1, 2026
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumkovshumkovshumkov approved these changes
@antouhouantouhouAwaiting requested review from antouhou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.24.0

Development

Successfully merging this pull request may close these issues.

2 participants

@shuplenkov@shumkov