Skip to content

feat: varint protocol version - #758

Merged
QuantumExplorer merged 63 commits into
v0.24-devfrom
feat/varintProtocolVersion
Jan 26, 2023
Merged

feat: varint protocol version#758
QuantumExplorer merged 63 commits into
v0.24-devfrom
feat/varintProtocolVersion

Conversation

@QuantumExplorer

@QuantumExplorerQuantumExplorer commented Jan 26, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

We used to using a u32 prepended to each message for the version. This PR changes this to a varint. This is to save space.

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

QuantumExplorerand others added 30 commits January 20, 2023 10:29
@QuantumExplorer
refactor: use a trait to remove the need for some functions
3817336
@QuantumExplorer
partial work
a6b85bf
@QuantumExplorer
commit
d277a55
@QuantumExplorer
more work
ad9ba14
@QuantumExplorer
more formatting
5a9f3b6
@QuantumExplorer
more fixes
dd67eb3
@QuantumExplorer
more fixes
4af9a7c
@QuantumExplorer
more fixes
937a555
@QuantumExplorer
removed duplication
c90541c
@QuantumExplorer
more fixes
85f54ca
@QuantumExplorer
more fixes
2848060
@QuantumExplorer
compiles
5523bb8
@QuantumExplorer
more refactoring
9c03799
@QuantumExplorer
more work
2d2a13c
@QuantumExplorer
more refactoring
edc0eb2
@QuantumExplorer
compiles again
0c4fd9b
@QuantumExplorer
more fixes
802adf2
@QuantumExplorer
more fixes
b7604f6
@QuantumExplorer
more fixes
7919376
@qrayven
fix error conversion
c2ea87e
@QuantumExplorer
more fixes
2a8aac0
@jawid-h
chore: fix error in getting required fields
14656fe
@jawid-h
chore: update json paths
ace400f
@QuantumExplorer
Merge branch 'refactor/documentTypes' of github.com:dashpay/platform …
cb19c24
…into refactor/documentTypes
@QuantumExplorer
dpp tests passing
b5d829e
@QuantumExplorer
small update
6c6ab00
@QuantumExplorer
small update
3521c8f
@QuantumExplorer
added more tests
00c7a76
@QuantumExplorer
changed document types
4cd33a9
@qrayven@QuantumExplorer
fix: remove recusion when insertin DocumentType (#757)
2b6f784
Co-authored-by: Quantum Explorer <quantum@dash.org>
@qrayven

qrayven commented Jan 26, 2023

Copy link
Copy Markdown
Contributor

LGTM, I didn't look that much into details, but I'm just wondering whether decoding collisions are possible. I mean, when the continuation bytes of varInt match the bytes from the payload

qrayven
qrayven previously approved these changes Jan 26, 2023
View reviewed changes
shumkov
shumkov previously approved these changes Jan 26, 2023
View reviewed changes
Comment threadpackages/js-dpp/test/integration/document/DocumentFacade.spec.js
Comment threadpackages/rs-dpp/src/util/deserializer.rs Outdated
Comment threadpackages/rs-dpp/src/util/deserializer.rs Outdated
Comment threadpackages/rs-dpp/src/util/deserializer.rs Outdated
Comment threadpackages/rs-dpp/src/identity/identity.rs
Comment threadpackages/rs-dpp/src/document/document_stub.rs Outdated
Comment threadpackages/rs-dpp/src/document/document_stub.rs Outdated
Comment threadpackages/rs-dpp/src/document/document_stub.rs Outdated
Comment threadpackages/rs-dpp/src/decode_protocol_entity_factory.rs Outdated
Comment threadpackages/rs-dpp/src/data_contract/data_contract.rs Outdated
@QuantumExplorerQuantumExplorer added this to the v0.24.0 milestone Jan 26, 2023
@QuantumExplorer
QuantumExplorer merged commit 9bf129a into v0.24-devJan 26, 2023
@QuantumExplorer
QuantumExplorer deleted the feat/varintProtocolVersion branch January 26, 2023 17:47
@QuantumExplorerQuantumExplorer mentioned this pull request Jun 4, 2026
Open
5 tasks
shumkov added a commit that referenced this pull request Jun 4, 2026
@shumkov@claude
fix(drive-abci): migrate Orchard shielded verifier to orchard 0.14
954b40d
The grovedb develop bump in this PR pulls orchard 0.13.1 -> 0.14.0 via
grovedb-commitment-tree (grovedb#758, an Orchard circuit-soundness fix).
orchard 0.14 changed the bundle-reconstruction API; adapt the consensus
verifier (reconstruct_and_verify_bundle) preserving exact acceptance semantics:
- Action::from_parts now returns Result (was Option). Keep the IdentityRk
rejection (same message) and KEEP the new InvalidEpk rejection (the soundness
fix#758 ships). ActionFromPartsError is #[non_exhaustive] -> unknown future
variants default to reject, never accept.
- Bundle::from_parts -> Bundle::try_from_parts(.., ProofSizeEnforcement::Unenforced).
Unenforced matches 0.13 (no proof-size check), keeping consensus acceptance
byte-for-byte; Strict would add a new rejection that did not exist before.
- Spend-auth signatures stay attached inline to each Action, so
action<->signature pairing/ordering is preserved structurally.
Add a direct orchard dep on rs-drive-abci pinned to the same git tag
grovedb-commitment-tree resolves to (cargo unifies to one orchard build) so
ProofSizeEnforcement / ActionFromPartsError can be named. Migration is confined
to this one verifier file; all other shielded code (rs-dpp builder,
rs-platform-wallet, wasm-dpp2) compiles unchanged.
Validated: 143 drive-abci shielded tests pass (0 failed), incl. valid-proof
acceptance and security-audit rejection (mutated value_balance, zeroed
spend-auth/binding sigs) round-trips with real Halo 2 proofs from the 0.14
builder. v11 consensus regression test unaffected and green.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@shumkovshumkov mentioned this pull request Jun 4, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumkovshumkovshumkov left review comments
@antouhouantouhouAwaiting requested review from antouhou
+1 more reviewer
@qrayvenqrayvenqrayven left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.24.0

Development

Successfully merging this pull request may close these issues.

6 participants

@QuantumExplorer@qrayven@shumkov@jawid-h@antouhou@pshenmic