Skip to content

feat(dashmate): high-performance nodes registration with setup command - #794

Merged
shumkov merged 111 commits into
v0.24-devfrom
register-hpmn
Mar 28, 2023
Merged

feat(dashmate): high-performance nodes registration with setup command#794
shumkov merged 111 commits into
v0.24-devfrom
register-hpmn

Conversation

@shumkov

@shumkovshumkov commented Feb 20, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Core 19 goes with HPMN and we need to provide a good UX to start any types of nodes for mainnet and testnet

What was done?

  • Allow registering full nodes and masternodes for testnet and mainnet including HP with setup command
  • Reworked setup command UX
  • Refactored obtaining SSL certificates

How Has This Been Tested?

Manually

Breaking Changes

  • Ports for testnet are changed to 1443 for HTTP and 36656 for p2p

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

thephez
thephez reviewed Feb 21, 2023
View reviewed changes

@thephezthephez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions (still looking at other stuff)

Comment threadpackages/dashmate/src/commands/setup.js Outdated
Comment threadpackages/dashmate/src/commands/setup.js Outdated
thephez
thephez reviewed Feb 21, 2023
View reviewed changes
Comment threadpackages/dashmate/src/listr/tasks/setup/setupRegularPresetTaskFactory.js Outdated
thephez
thephez reviewed Feb 21, 2023
View reviewed changes
Comment threadpackages/dashmate/src/listr/tasks/setup/setupRegularPresetTaskFactory.js Outdated
thephez
thephez reviewed Feb 21, 2023
View reviewed changes
Comment threadpackages/dashmate/src/listr/tasks/setup/setupRegularPresetTaskFactory.js Outdated
thephez
thephez reviewed Feb 21, 2023
View reviewed changes
Comment threadpackages/dashmate/src/listr/tasks/setup/setupRegularPresetTaskFactory.js Outdated
@qwizzieqwizzie mentioned this pull request Mar 17, 2023
Closed
shumkovand others added 18 commits March 17, 2023 21:27
@shumkov
Merge branch 'v0.24-dev' into register-hpmn
3ade76c
# Conflicts:
#	.pnp.cjs
#	packages/dashmate/src/commands/setup.js
#	packages/dashmate/src/listr/tasks/setup/setupRegularPresetTaskFactory.js
#	yarn.lock
@shumkov
Merge branch 'v0.24-dev' into register-hpmn
5febd06
# Conflicts:
#	.pnp.cjs
#	yarn.lock
@shumkov
chore: remove unnecessary dependency
3071d59
@shumkov
chore(drive): register masternode
d51bcef
@shumkov
chore(drive): register masternode
c06477c
@shumkov
fix: register guide flow
5b0fd7f
@strophy
chore: add more detailed messages to mn guide
3fe10d3
@strophy
Merge branch 'register-hpmn-strings' into register-hpmn
6d082c4
@shumkov
chore: use hint
b294134
@shumkov
Merge branch 'register-hpmn' of github.com:dashpay/platform into regi…
cb24c7d
…ster-hpmn
@shumkov
feat: bring things together
99f0ee0
@shumkov
feat: validate if preset already configured
d95734a
@strophy
chore: string formatting
12f0b81
@strophy
Merge branch 'register-hpmn' of github.com:dashpay/platform into regi…
e238bd4
…ster-hpmn
@shumkov
Merge branch 'v0.24-dev' into register-hpmn
84ed065
@shumkov
fix: do not ask for ip and ports for full nodes
27753ad
@shumkov
feat: ip and port validation
c9b0378
@strophy
chore: intro text updates and backtick syntax
5ffa6ab
thephez
thephez reviewed Mar 27, 2023
View reviewed changes

@thephezthephez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 A few more comments/suggestions to consider

Comment threadpackages/dashmate/README.md Outdated
Comment threadpackages/dashmate/README.md Outdated
Comment threadpackages/dashmate/README.md Outdated
Comment threadpackages/dashmate/README.md Outdated
Comment threadpackages/dashmate/README.md Outdated
Comment threadpackages/dashmate/README.md Outdated
Comment threadpackages/dashmate/README.md Outdated
Comment threadpackages/dashmate/src/commands/stop.js Outdated
@thephez

thephez commented Mar 27, 2023

Copy link
Copy Markdown
Collaborator

@strophy 🙈 Sorry, I see you just acked 2 minutes ago. They're only suggestions so do as you see fit 🙂

@shumkov
shumkov dismissed stale reviews from strophy and shuplenkov via 037d33bMarch 27, 2023 14:37
strophyand others added 8 commits March 28, 2023 01:42
@strophy@thephez
Update packages/dashmate/README.md
0792603
Co-authored-by: thephez <thephez@users.noreply.github.com>
@strophy@thephez
Update packages/dashmate/README.md
00782d2
Co-authored-by: thephez <thephez@users.noreply.github.com>
@strophy@thephez
Update packages/dashmate/README.md
48c2180
Co-authored-by: thephez <thephez@users.noreply.github.com>
@strophy@thephez
Update packages/dashmate/README.md
1b86a84
Co-authored-by: thephez <thephez@users.noreply.github.com>
@strophy@thephez
Update packages/dashmate/src/commands/stop.js
83c2f2a
Co-authored-by: thephez <thephez@users.noreply.github.com>
@strophy@thephez
Update packages/dashmate/README.md
12237ae
Co-authored-by: thephez <thephez@users.noreply.github.com>
@strophy@thephez
Update packages/dashmate/README.md
b6c80bc
Co-authored-by: thephez <thephez@users.noreply.github.com>
@strophy@thephez
Update packages/dashmate/README.md
f6aa998
Co-authored-by: thephez <thephez@users.noreply.github.com>
strophy
strophy previously approved these changes Mar 27, 2023
View reviewed changes
thephez
thephez previously approved these changes Mar 27, 2023
View reviewed changes

@thephezthephez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work guys! 🚀

shuplenkov
shuplenkov previously approved these changes Mar 27, 2023
View reviewed changes
@shumkov
shumkov dismissed stale reviews from shuplenkov, thephez, and strophy via 302edbbMarch 28, 2023 05:35
antouhou
antouhou approved these changes Mar 28, 2023
View reviewed changes

@antouhouantouhou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@shumkov
shumkov merged commit 4662f4a into v0.24-devMar 28, 2023
@shumkov
shumkov deleted the register-hpmn branch March 28, 2023 09:51
@shumkovshumkov mentioned this pull request Apr 19, 2023
Closed
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@strophystrophyAwaiting requested review from strophy
@thephezthephezAwaiting requested review from thephez
2 more reviewers
@antouhouantouhouantouhou approved these changes
@shuplenkovshuplenkovshuplenkov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.24.0

Development

Successfully merging this pull request may close these issues.

5 participants

@shumkov@shuplenkov@thephez@antouhou@strophy