Uh oh!
There was an error while loading. Please reload this page.
fix(rs-dpp): Remove overflows - #818
Closed
qrayven wants to merge 12 commits into
Closed
Conversation
qrayvenforce-pushed
the
fix/remove-overflow
branch
from
March 14, 2023 09:25
6502205 to
7ae7c6eCompareqrayven
commented
Mar 31, 2023
ContributorAuthor
Closed due to of too many conflicts |
This was referenced Jul 20, 2026
6 tasks
bfoss765 added a commit
to bfoss765/platform
that referenced
this pull request
Aug 5, 2026
…field The key-wallet pin bump takes key-wallet dashpay#818, which dropped `generated_at` / `used_at` from `#[repr(C)] FFIAddressInfo`. `build_ios.sh` regenerates that crate's cbindgen header into DashSDKFFI.xcframework, so a fresh framework build left AddressPool.swift referencing a member the C struct no longer has: error: value of type 'FFIAddressInfo' has no member 'generated_at' `generatedAt` is kept (public API, no in-repo or observable change) and pinned to the Unix epoch. That is not a substituted value: every key-wallet `AddressInfo` constructor set `generated_at: 0` ("Should use actual timestamp"), so the property has always evaluated to the epoch. Both it and `used` now document the new `AddressState` model, including that a `Reserved` address reports `used == false` and that reservation state is not observable across the C surface. Also settles the persistence round-trip question raised in review. `generated_at` / `used_at` were never serialized — `CoreAddressEntryFFI` has no field for them, and `address_info_from_ffi` was the only producer, from the literals `0` / `Some(0)` — so dropping them is lossless. `Reserved { at }` genuinely has no slot in that schema and would reload as `Available`, but nothing in platform reserves addresses (no caller of `next_receive_address_and_reserve` / `next_unused_and_reserve` in the workspace), so the loss is unreachable today rather than live. The emit path now spells the `Reserved` arm out and warns instead of silently flattening it, the schema field documents the constraint, and a new test pins the behavior so a future reserving caller surfaces as a schema decision. Verified: `cargo check --workspace --all-targets` clean; platform-wallet 513 passed, platform-wallet-ffi 221 passed; rustfmt clean; scoped clippy (the CI invocation) clean. Swift verified by type-checking the whole SwiftDashSDK module under -swift-version 6 -warnings-as-errors against the cbindgen headers regenerated from the new pin — clean, and the pre-fix source reproduces the reviewer's exact error against the same headers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Merged
6 tasks
QuantumExplorer added a commit
that referenced
this pull request
Aug 21, 2026
The pin moves past the direction-aligned merge so that grovedb #818 (verifier reads a synthesized path-component layer's direction off the proof) is in the tree: without it a descending cursor proof either fails subset verification with "Cannot verify lower bound of queried range" or, on a key-bearing opening node, verifies to an empty result set for a subtree that exists. Adaptations ride along: - indexed-axis reads return IndexedAxisEntry<T> (ordering_value, primary_key, resolved value) instead of (T, key) tuples; the ranked and having executors and verifiers project to the ranking pair - TreeType::PrivateDocumentStore arms fail closed in the two generic empty-tree constructors (its entry size is not carried by TreeType) - CommitmentTree::append_many_raw takes a GroveVersion Fee goldens, query suites and the abci query tests are unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes potential overflows and unifies types for common fileds containg numbers
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only