Skip to content

docs: supported Node.JS version and dashmate command description - #825

Merged
jaboski merged 13 commits into
v0.24-devfrom
docs/update_supported_node_version_and_dashmate_command_descr
Mar 20, 2023
Merged

docs: supported Node.JS version and dashmate command description#825
jaboski merged 13 commits into
v0.24-devfrom
docs/update_supported_node_version_and_dashmate_command_descr

Conversation

@jaboski

@jaboskijaboski commented Mar 15, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

As we are not supporting higher than 16 version of nodeJS, the documentation for platform is misleading.
Dashmate reset command description is also wrongly placed and mixed with reindex command.

What was done?

Update platform, DAPI and dashmate docs about currently supported nodeJS version (from v16+ to v16).
Fix incorrect description for dashmate reset command which was partly pasted into reindex command description.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

thephez
thephez requested changes Mar 15, 2023
View reviewed changes

@thephezthephez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaboski Thanks for updating! I left a few questions and suggestions for you to look at.

Comment threadREADME.md
Comment threadpackages/dapi/README.md Outdated
Comment threadpackages/dashmate/README.md Outdated
Comment threadpackages/dashmate/README.md
Comment threadpackages/dashmate/README.md
jaboskiand others added 4 commits March 16, 2023 10:28
@jaboski@thephez
Update packages/dashmate/README.md
a3a8484
Co-authored-by: thephez <thephez@users.noreply.github.com>
@jaboski@thephez
Update packages/dashmate/README.md
f84ae33
Co-authored-by: thephez <thephez@users.noreply.github.com>
@jaboski@thephez
Update packages/dashmate/README.md
e816cde
Co-authored-by: thephez <thephez@users.noreply.github.com>
@jaboski
Updates based on comments, reset descr fix
2811412
thephez
thephez reviewed Mar 16, 2023
View reviewed changes

@thephezthephez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more questions/suggestions to consider

Comment threadpackages/dashmate/README.md
Comment threadpackages/dashmate/README.md
Comment threadpackages/dashmate/README.md
Comment threadpackages/dashmate/README.md Outdated
Comment threadREADME.md Outdated
jaboskiand others added 5 commits March 16, 2023 14:03
@jaboski@thephez
Any v16 version
fe19aa0
Co-authored-by: thephez <thephez@users.noreply.github.com>
@jaboski
Add missing full node section
f7b1bb5
@jaboski@thephez
Update packages/dashmate/README.md
be485d5
Co-authored-by: thephez <thephez@users.noreply.github.com>
@jaboski@thephez
Update packages/dashmate/README.md
f730e30
Co-authored-by: thephez <thephez@users.noreply.github.com>
@jaboski
Separate hard reset subsection
6b1bce6
thephez
thephez previously approved these changes Mar 16, 2023
View reviewed changes
Comment threadpackages/dashmate/README.md
@shumkovshumkov changed the title Docs/update supported node version and dashmate command descriptiondocs: supported Node.JS version and dashmate command descriptionMar 20, 2023
shumkov
shumkov approved these changes Mar 20, 2023
View reviewed changes

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaboski
jaboski merged commit cd27508 into v0.24-devMar 20, 2023
@jaboski
jaboski deleted the docs/update_supported_node_version_and_dashmate_command_descr branch March 20, 2023 15:28
QuantumExplorer added a commit that referenced this pull request Aug 22, 2026
@QuantumExplorer@claude
fix(drive): read ranked and having pages through keys-only indexed-ax…
71d49c7
…is reads
The ranked and having-range executors only rank — every entry was
projected to its (value, key) pair and the resolved primary value
discarded — yet the resolving reads paid up to k primary point reads
per page through the caller's transaction, outside the pinned iterator
view the page came from, so a primary deleted or rewritten by a commit
in between could surface as CorruptedData or pair a newer primary with
an older page. grovedb's keys-only reads (dashpay/grovedb#824,
indexed_*_top_k_paginated_keys / indexed_*_range_keys) return the
ranking pairs straight from the secondary view and never open the
primary; the executors and the e2e test helpers use them.
grovedb pinned to develop head f52adb64, which also carries the
append-only storage accounting (dashpay/grovedb#822 via #825/#826:
write churn reported as replaced bytes, each note's permanent bytes
charged once) and the keys-only projection on the unified PathQuery
(#827). The genesis shielded seeding test passes the grove version to
the commitment tree's save/commit_mmr, which now take it.
The two shielded fee-floor tests (flat fee >= estimated write cost)
remain red at this pin: the estimate for a 1-action transfer is now
~397M credits (storage 133M + processing 264M, the epoch's replaced
bytes at the processing rate) against the 131M flat fee — down from
18.5B at the previous pin, and the subject of the shielded pricing
change that follows this PR.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@QuantumExplorerQuantumExplorer mentioned this pull request Aug 22, 2026
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumkovshumkovshumkov approved these changes
@thephezthephezthephez left review comments
@shuplenkovshuplenkovAwaiting requested review from shuplenkov
@pshenmicpshenmicAwaiting requested review from pshenmic
@antouhouantouhouAwaiting requested review from antouhou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaboski@shumkov@thephez@shuplenkov