Uh oh!
There was an error while loading. Please reload this page.
ci: dashmate release script fix - #836
Merged
Merged
Conversation
5 tasks
5 tasks
QuantumExplorer added a commit
that referenced
this pull request
Aug 26, 2026
…ath_query; bump grovedb to 6b34ea81
grovedb is also retiring the per-axis trusted-read wrappers
(indexed_*_top_k_paginated_keys, indexed_*_range_keys, ...) to
crate-internal engine status: run_path_query over the same axis
PathQuery is the only public read surface, so one request shape serves
reads (run_path_query), proving (prove_query) and verification
(verify_path_query).
- execute_top_k_no_proof: indexed_*_top_k_paginated_keys →
run_path_query(PathQuery::new_axis(AxisQuery::top_k(..).keys_only()))
destructuring PathQueryRun::AxisKeys { keys, skipped }
- execute_range_no_proof: indexed_*_range_keys →
run_path_query(PathQuery::new_axis(AxisQuery::bounded(..).keys_only()))
- test helpers in ranked_index_e2e_tests and ranked_group_drain moved
off the retired wrappers onto the same route
The keys-only projection preserves the old wrappers' read cost: the
ranking pairs come straight off the pinned secondary view, no primary
values resolved.
Requires the attested-skip field on PathQueryRun's axis variants
(grovedb #836), so the grovedb pin moves 753a11f1 → 6b34ea81 (current
grovedb develop; merged commits only). rs-drive gains a direct
grovedb-query dependency at the same rev for the AxisQuery builder
(grovedb re-exports it at the root only after dashpay/grovedb#839).
Fallout from the bump: grovedb #833 made transaction
commit/rollback/savepoint return grovedb_storage::Error directly, so
drive-abci's three RocksDBError(e) re-wraps become StorageError(e).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>QuantumExplorer added a commit
that referenced
this pull request
Aug 26, 2026
…prover retirement grovedb #836 gave the unified unproved read the attested skip (`PathQueryRun::AxisKeys/AxisEntries { .., skipped }`), and #839 retired the standalone indexed-axis provers, verifiers and read entry points outright — PathQuery is grovedb's only public surface for the family. The pin moves to that head and platform completes the unification it was waiting on: - Single-prefix unproved reads (ranked top-k and having-range) are one `run_path_query` over `PathQuery::new_axis` with the keys-only projection; the per-axis triple dispatches are gone, and the rank attestation maps from the new `skipped` field (its absence on a paginated read is corrupted state, not a default). - Single-prefix proofs are `prove_query(new_axis_top_k / new_axis_bounded)`; since transactional proving no longer exists anywhere, the committed-state-only guard covers single-prefix and branched proves alike. - Single-prefix verification matches `VerifiedPathQuery::AxisEntries { root_hash, entries, skipped }` through the same shared mappers as the branched arms. - Every read, proof and verification on both surfaces now builds exactly one PathQuery per external query; rs-drive re-exports `grovedb_query` so downstream crates can construct axis queries. Two semantic upgrades ride the retirement, both now pinned by tests: - A bound matching nothing against an EMPTY secondary proves: the envelope commits the element's empty secondary, authenticating complete absence instead of refusing ("Cannot create proof for empty tree" is gone from this surface; drive-abci's InvalidArgument mapping for that class is vestigial here and kept as dead-defensive). - The limit binds by RECONSTRUCTION, not echo: the verifier re-executes the proof under the queried limit, so an exhausted-walk proof is a complete answer under any cap that admits it (the old echo check rejected that soundly-verifiable case), while the dangerous direction — a proof truncated by a smaller limit verified under a larger cap — is rejected for missing coverage. The tamper test now pins BOTH directions; it previously exercised only the benign one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Dashmate release script contains some errors, which makes impossible to release it.
What was done?
Fixed dashmate release script
How Has This Been Tested?
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only