Skip to content

feat(wasm-dpp): validate_state_transition_identity_signature binding and test - #865

Merged
antouhou merged 8 commits into
v0.24-devfrom
feat-validate-st-identity-signature
Mar 31, 2023
Merged

feat(wasm-dpp): validate_state_transition_identity_signature binding and test#865
antouhou merged 8 commits into
v0.24-devfrom
feat-validate-st-identity-signature

Conversation

@antouhou

@antouhouantouhou commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@antouhou
antouhou requested a review from shumkov as a code ownerMarch 28, 2023 12:53
@antouhouantouhou changed the title Feat validate st identity signaturefeat(wasm-dpp) validate_state_transition_identity_signature binding and testMar 28, 2023
@antouhou
refactor more tests
353e145
@antouhou
finish the rest of the tests and fixed some bugs
7760b75
@antouhou
fix clippy errors
7882c30
@antouhou
reformat
9bdca2b
@antouhou
Merge branch 'v0.24-dev' into feat-validate-st-identity-signature
7fad414
# Conflicts:
#	packages/rs-dpp/src/identity/state_transition/asset_lock_proof/chain/chain_asset_lock_proof_structure_validator.rs
#	packages/rs-dpp/src/state_transition/validation/validate_state_transition_state.rs
@antouhouantouhou changed the title feat(wasm-dpp) validate_state_transition_identity_signature binding and testfeat(wasm-dpp): validate_state_transition_identity_signature binding and testMar 30, 2023
markin-io
markin-io suggested changes Mar 30, 2023
View reviewed changes
Comment thread...test/unit/stateTransition/validation/validateStateTransitionIdentitySignatureFactory.spec.js Outdated
Comment thread...test/unit/stateTransition/validation/validateStateTransitionIdentitySignatureFactory.spec.js Outdated
@antouhou
antouhou merged commit bc9cdff into v0.24-devMar 31, 2023
@antouhou
antouhou deleted the feat-validate-st-identity-signature branch March 31, 2023 07:39
QuantumExplorer pushed a commit that referenced this pull request Apr 20, 2023
@antouhou@QuantumExplorer
feat(wasm-dpp): validate_state_transition_identity_signature binding …
c6ad2f3
…and test (#865)
markin-io pushed a commit that referenced this pull request Apr 24, 2023
@antouhou@markin-io
feat(wasm-dpp): validate_state_transition_identity_signature binding …
c03e52f
…and test (#865)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumkovshumkovAwaiting requested review from shumkov
@jawid-hjawid-hAwaiting requested review from jawid-h
@shuplenkovshuplenkovAwaiting requested review from shuplenkov
2 more reviewers
@markin-iomarkin-iomarkin-io approved these changes
@fominokfominokfominok approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antouhou@markin-io@fominok