Skip to content

fix: llmqType must be equal to one of the allowed values - #884

Merged
strophy merged 1 commit into
v0.24-devfrom
fix/dashmate-config-llmqtype
Apr 4, 2023
Merged

fix: llmqType must be equal to one of the allowed values#884
strophy merged 1 commit into
v0.24-devfrom
fix/dashmate-config-llmqtype

Conversation

@strophy

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Dashmate integration on testnet was failing due to inability to select llmqType 6, which is required on testnet.

fatal: [hp-masternode-3]: FAILED! => changed=false cmd:
- yarn
- dashmate
- restart
delta: '0:00:11.555743'
end: '2023-04-04 13:05:12.249023'
msg: non-zero return code
rc: 1
start: '2023-04-04 13:05:00.693280'
stderr: |2-
InvalidConfigFileFormatError: Invalid
'/home/dashmate/.dashmate/config.json' config format:
config/platform/drive/abci/validatorSet/llmqType must be equal to one of
the allowed values
stderr_lines: <omitted>
stdout: ''
stdout_lines: <omitted>

What was done?

Update enum llmqType

How Has This Been Tested?

In testing

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophystrophy added this to the v0.24.0 milestone Apr 4, 2023

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@strophy
strophy merged commit 5e5f5dd into v0.24-devApr 4, 2023
@strophy
strophy deleted the fix/dashmate-config-llmqtype branch April 4, 2023 15:36
@markin-iomarkin-io mentioned this pull request Apr 26, 2023
5 tasks
QuantumExplorer added a commit that referenced this pull request Jul 14, 2026
…hip, node id, restore & lifecycle fixes
Bumps the pin for rust-dashcore #882 (operator gap-limit extension),
#884 (platform node id = Tenderdash SHA256[0..20], fixing our #883)
and #885 (dedicated PlatformNodeId newtype). Addresses the review
blockers on the masternode feature:
- Ownership maps are rebuilt from the managed provider pools: operator
scans through the pool's high-water mark (not a hardcoded 20-window)
so #882/restored beyond-gap keys match; platform node ownership
reads the persisted EdDSA batch with node ids recomputed under #884
(the lifecycle is seedless, so seed-derivation never fired).
- Platform-node key batch is threaded restore→FFI→pool as typed EdDSA
entries; MasternodeSync never downgrades a true ownership flag on a
transient absent signal.
- Address-pool restore keeps prederived typed BLS/EdDSA keys instead of
clobbering them with the ECDSA-shaped FFI row.
- Claim button gated off (withdrawal is still a stub); wallet deletion
purges PersistentMasternode; list_masternodes writes empty outputs
before fallible lookups.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@strophy@shumkov