Skip to content

feat: add request_block_headers_from_peer to RequestSender - #489

Closed
xdustinface wants to merge 2 commits into
v0.42-devfrom
feat/send-to-peer
Closed

feat: add request_block_headers_from_peer to RequestSender#489
xdustinface wants to merge 2 commits into
v0.42-devfrom
feat/send-to-peer

Conversation

@xdustinface

Copy link
Copy Markdown
Collaborator

Add SendMessageToPeer variant to NetworkRequest and request_block_headers_from_peer to RequestSender so sync managers can request block headers from specific peers.

Based on:

Deduplicate `GetHeaders` → `GetHeaders2` upgrade logic from `send_to_single_peer`
and `send_distributed` into a shared `send_message_to_peer` method.
Add `SendMessageToPeer` variant to `NetworkRequest` and
`request_block_headers_from_peer` to `RequestSender` so sync managers
can request block headers from specific peers.
@coderabbitai

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/send-to-peer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from refactor/send-to-peer to v0.42-devMarch 3, 2026 16:03
@github-actionsgithub-actionsBot added the merge-conflict The PR conflicts with the target branch. label Mar 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them.

@xdustinface

Copy link
Copy Markdown
CollaboratorAuthor

Part of #490 now.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflictThe PR conflicts with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@xdustinface