Skip to content

Mark test_worker_reconnects_mid_compute* tests as flaky - #5378

Merged
jrbourbeau merged 3 commits into
dask:mainfrom
jrbourbeau:flaky-test
Oct 5, 2021
Merged

Mark test_worker_reconnects_mid_compute* tests as flaky#5378
jrbourbeau merged 3 commits into
dask:mainfrom
jrbourbeau:flaky-test

Conversation

@jrbourbeau

@jrbourbeaujrbourbeau commented Oct 1, 2021

Copy link
Copy Markdown
Member

xref #5377

@jrbourbeaujrbourbeau mentioned this pull request Oct 1, 2021
Merged
jakirkham
jakirkham approved these changes Oct 1, 2021
View reviewed changes

@jakirkhamjakirkham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James! 😄

@jakirkham

jakirkham commented Oct 1, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Seeing test_stress_creation_and_deletion fail on CI here and here, which is already noted as a flaky test in issue ( #5172 ).

Also seeing test_client_timeout fail on CI here. Not seeing any open issues about it.

@jrbourbeau

jrbourbeau commented Oct 5, 2021

Copy link
Copy Markdown
MemberAuthor

xref #5393 for test_stress_creation_and_deletion

@crusaderky

crusaderky commented Oct 5, 2021

Copy link
Copy Markdown
Collaborator

The same should also be applied to test_worker_reconnects_mid_compute

@crusaderky

crusaderky commented Oct 5, 2021

Copy link
Copy Markdown
Collaborator

According to my latest stress test, test_client_timeout fails exclusively on MacOS.

@jrbourbeaujrbourbeau changed the title Mark test_worker_reconnects_mid_compute_multiple_states_on_scheduler as flakyMark test_worker_reconnects_mid_compute* tests as flakyOct 5, 2021
@jrbourbeau

jrbourbeau commented Oct 5, 2021

Copy link
Copy Markdown
MemberAuthor

Just pushed a commit to mark test_worker_reconnects_mid_compute as flaky too.

@jakirkham for reference, @crusaderky is running a bunch of stress tests on the distributed test suite to see what tests fail, how often, etc. Let's leave test_client_timeout for after we have the results of those stress tests. Right now I'm mostly concerned about test_worker_reconnects_mid_compute* and test_stress_creation_and_deletion as they are failing at a high rate.

@jakirkham

jakirkham commented Oct 5, 2021

Copy link
Copy Markdown
Member

Sure am mostly just trying to get a sense of what flaky test failures we are dealing with since there appear to be several

@jrbourbeau
jrbourbeau merged commit 07d8e4c into dask:mainOct 5, 2021
@jrbourbeau
jrbourbeau deleted the flaky-test branch October 5, 2021 21:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkhamjakirkhamjakirkham approved these changes
@crusaderkycrusaderkycrusaderky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jrbourbeau@jakirkham@crusaderky