Skip to content

skipped test_all #283

Description

@ev-br

5473d84 skipped a test, tests/test_all.py, which started failing after adding an unrelated tests/test_torch.py.
The test itself seems to probe the contents of internal implementation modules, and fails essientially on this:

In [16]: from array_api_compat.common import _aliases

In [17]: all_names = set(n for n in _aliases.__all__ if not n.startswith('_'))

In [18]: dir_names = set(n for n in dir(_aliases) if not n.startswith('_'))

In [19]: dir_names - all_names      # not empty, failure
Out[19]: 
{'NamedTuple',
 'TYPE_CHECKING',
 'annotations',
 'array_namespace',
 'device',
 'inspect',
 'is_cupy_namespace'}

I've to admit I'm not sure what the intention is, this seems to be a Chesterton fence of sorts. Do you happen to remember the context @asmeurer ?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions