Uh oh!
There was an error while loading. Please reload this page.
Fix sign() for torch and cupy - #137
Conversation
Neither propagate nans correctly, and torch does not support complex numbers. Fixesdata-apis#136
asmeurer
commented
May 10, 2024
#136 should be resolved before this is merged, specifically, we should decide if it's worth fixing the sign(nan) special case, and if we want to keep that special case at all. Regardless of that, though, we should keep the torch complex handling, as it's very straightforward to implement. |
asmeurer
commented
May 10, 2024
It seems that torch has gained quite a few new test failures since the last time we ran them. I don't know if that's because of a test suite update or a torch update. |
asmeurer
commented
May 24, 2024
So based on a simple timing test on PyTorch CPU, is 3-10x slower than |
asmeurer
commented
Sep 3, 2024
It sounds like this will be useful, so I'm going to merge. |
Neither propagate nans correctly, and torch does not support complex numbers.
Fixes#136