Uh oh!
There was an error while loading. Please reload this page.
TST: run parameterized tests on more libraries - #227
Merged
Conversation
This was referenced Jan 6, 2025
Merged
crusaderkyforce-pushed
the
test_more_backends
branch
3 times, most recently
from
January 8, 2025 12:15
d8019e5 to
4e7603aComparecrusaderkyforce-pushed
the
test_more_backends
branch
from
January 11, 2025 22:40
4e7603a to
ec28ffdComparecrusaderkyforce-pushed
the
test_more_backends
branch
2 times, most recently
from
January 16, 2025 13:31
624ae63 to
f321555Comparecrusaderky
commented
Jan 16, 2025
ContributorAuthor
@ev-br this is ready for review and merge |
crusaderkyforce-pushed
the
test_more_backends
branch
from
January 20, 2025 00:13
f321555 to
02fb925Compare
Closed
lucascolley
approved these changes
Jan 24, 2025
lucascolley
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks!
Q: (out of scope) shouldn't we add an is_array_api_strict_array function, to match is_array_api_strict_namespace?
Yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asarray()Q: (out of scope) shouldn't we add an
is_array_api_strict_arrayfunction, to matchis_array_api_strict_namespace?