Uh oh!
There was an error while loading. Please reload this page.
MAINT: depend on array-api-compat - #47
Conversation
lucascolley
commented
Dec 6, 2024
Why? I was under the impression that "unpinned" git submodules are not bumped unless someone deliberately does so. All of SciPy's git submodules are unpinned. |
f052362 to
9fe035dComparecrusaderky
commented
Dec 6, 2024
I wasn't aware of that, good to know |
7be17b2 to
82a3b6dCompareI think we will want to document somewhere what we are relying on from array-api-compat, or otherwise indicate which versions of array-api-compat this can depend on or be co-vendored with. I think I'm fine with something along the lines of "we aim for compatibility with the latest released version of array-api-compat, and your mileage may vary with older or dev versions". |
494064b to
b06cbccComparecrusaderky
commented
Dec 6, 2024
@lucascolley this is ready for review. Could you please enable workflows for this PR? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
crusaderky
commented
Dec 6, 2024
crusaderky
commented
Dec 6, 2024
I executed |
lucascolley
commented
Dec 6, 2024
Unfortunately, I believe manual approval has to be given every time, for first-time contributors. Feel free to submit a separate PR with a trivial change if you want to unblock that. |
lucascolley
commented
Dec 6, 2024
looks like you may want to bump the version of |
crusaderky
commented
Dec 6, 2024
|
f0823e2 to
3a659d7Comparecrusaderky
commented
Dec 6, 2024
I've rebased this PR on top of #48 to get a more readable pixi.lock diff |
3a659d7 to
7dbe0dfCompare8837f2a to
e3a2641CompareUh oh!
There was an error while loading. Please reload this page.
crusaderky
commented
Dec 6, 2024
@lucascolley all green; ready for final review and merge |
lucascolley
left a comment
There was a problem hiding this comment.
thanks a lot @crusaderky, this looks great!
I suppose the scope of this package expanding is a blessing and a curse :). We will need to update the 'scope' section of the docs, but I'm happy to tackle this separately.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ba8d391 to
7046ee5Comparecrusaderky
commented
Dec 9, 2024
@lucascolley all comments addressed; this should be ready for merge |
Uh oh!
There was an error while loading. Please reload this page.
lucascolley
commented
Dec 9, 2024
thanks! |

at(ENH: Test for read-only arrays array-api-compat#205)Follow-up: vendoring hook in scipy