Skip to content

MAINT: depend on array-api-compat - #47

Merged
lucascolley merged 4 commits into
data-apis:mainfrom
crusaderky:array-api-compat
Dec 9, 2024
Merged

MAINT: depend on array-api-compat#47
lucascolley merged 4 commits into
data-apis:mainfrom
crusaderky:array-api-compat

Conversation

@crusaderky

@crusaderkycrusaderky commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Follow-up: vendoring hook in scipy

@lucascolley

Copy link
Copy Markdown
Member

WIP: vendoring hook in scipy (if you merge this now, scipy will break!)

Note that this will break all third-party libraries that vendor array-api-extra through a unpinned git subproject, like scipy does.

Why? I was under the impression that "unpinned" git submodules are not bumped unless someone deliberately does so. All of SciPy's git submodules are unpinned.

@crusaderky

Copy link
Copy Markdown
ContributorAuthor

I was under the impression that "unpinned" git submodules are not bumped unless someone deliberately does so

I wasn't aware of that, good to know

@crusaderky
crusaderkyforce-pushed the array-api-compat branch 2 times, most recently from 7be17b2 to 82a3b6dCompareDecember 6, 2024 14:31
@lucascolley

lucascolley commented Dec 6, 2024

Copy link
Copy Markdown
Member

I think we will want to document somewhere what we are relying on from array-api-compat, or otherwise indicate which versions of array-api-compat this can depend on or be co-vendored with.

I think I'm fine with something along the lines of "we aim for compatibility with the latest released version of array-api-compat, and your mileage may vary with older or dev versions".

@crusaderky
crusaderkyforce-pushed the array-api-compat branch 2 times, most recently from 494064b to b06cbccCompareDecember 6, 2024 14:51
@crusaderky

Copy link
Copy Markdown
ContributorAuthor

@lucascolley this is ready for review. Could you please enable workflows for this PR?

@crusaderkycrusaderky changed the title [WIP] Add dependency to array-api-compatAdd dependency to array-api-compatDec 6, 2024
@crusaderky
crusaderky marked this pull request as ready for review December 6, 2024 14:52
Comment threadsrc/array_api_extra/_funcs.py
Comment threadtests/test_funcs.py
@crusaderky

Copy link
Copy Markdown
ContributorAuthor

Could you please unlock this?
image

@crusaderky

Copy link
Copy Markdown
ContributorAuthor

I executed rm pixi.lock && pixi run tests to update the lock; not sure if it's the correct process?

@lucascolley

Copy link
Copy Markdown
Member

rm pixi.lock && pixi run tests

pixi update should do

Could you please unlock this?

Unfortunately, I believe manual approval has to be given every time, for first-time contributors. Feel free to submit a separate PR with a trivial change if you want to unblock that.

@lucascolley

Copy link
Copy Markdown
Member

looks like you may want to bump the version of pixi used by the CI workflows, if your local version is newer

@crusaderky

Copy link
Copy Markdown
ContributorAuthor

Feel free to submit a separate PR with a trivial change if you want to unblock that.

#48

@crusaderky

Copy link
Copy Markdown
ContributorAuthor

I've rebased this PR on top of #48 to get a more readable pixi.lock diff

Comment threadsrc/array_api_extra/_lib/_compat.pyi
@crusaderky

Copy link
Copy Markdown
ContributorAuthor

@lucascolley all green; ready for final review and merge

@lucascolleylucascolley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @crusaderky, this looks great!

I suppose the scope of this package expanding is a blessing and a curse :). We will need to update the 'scope' section of the docs, but I'm happy to tackle this separately.

Comment threadpyproject.toml Outdated
Comment threadvendor_tests/__init__.py
Comment threadvendor_tests/_array_api_compat_vendor.py
Comment threaddocs/index.md
@crusaderky

Copy link
Copy Markdown
ContributorAuthor

@lucascolley all comments addressed; this should be ready for merge

Comment threadREADME.md Outdated
@lucascolleylucascolley changed the title Add dependency to array-api-compatMAINT: depend on array-api-compatDec 9, 2024
@lucascolley
lucascolley merged commit 09dc648 into data-apis:mainDec 9, 2024
@crusaderky
crusaderky deleted the array-api-compat branch December 9, 2024 13:41
@lucascolley

Copy link
Copy Markdown
Member

thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH/API: xp-bound namespaces, array-api-compat

2 participants

@crusaderky@lucascolley