Skip to content

Issue with test_clip #359

Description

@ndgrigorian
    | Falsifying example: test_clip(
    |     x=array(0, dtype=uint8),
    |     data=data(...),
    | )
    | Draw 1 (min.shape, max.shape): ((), ())
    | Draw 2 (min): array(0, dtype=uint8)
    | Draw 3 (max): array(0, dtype=uint16)
    | Draw 4 (kwargs): {'min': array(0, dtype=uint8), 'max': array(0, dtype=uint16)}

Per spec,

If either min or max is an array having a different data type than x, behavior is unspecified and thus implementation-dependent.

Clarified that behavior is only defined when x, min, and max resolve to arrays having the same data type.

It seems to me that this is a malformed test, and only cases where min and max are (or resolve to, but even that's a stretch per first condition) the type of x should be tested.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions