Skip to content

Computing the sign of a complex number #545

Description

@kgryte

Originally discussed in #153 (comment).

In order to add complex support to sign, we need to agree on the definition for complex numbers.

NumPy uses sqrt(z^2)/z while an arguably more common convention is x/|x|.

For paths forward we have 3 options:

  1. Use NumPy's definition.
  2. Use the more common convention used elsewhere (MATLAB, Julia, etc).
  3. Not support complex numbers in sign.

Questions

  • If we choose (2), given NumPy's potential v2 release, would NumPy be willing to introduce this breaking change?

See Also

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions