Uh oh!
There was an error while loading. Please reload this page.
Conversation
It is straightforward for CuPy to support the |
Uh oh!
There was an error while loading. Please reload this page.
0607525 to
138e963Comparekgryte
commented
May 12, 2021
Thanks, @leofang, for the review. This is ready for merge... |
lucascolley
commented
Aug 21, 2024
What was the motivation for choosing the |
kgryte
commented
Aug 21, 2024
@lucascolley See the API comparison linked to in the OP: https://github.com/data-apis/array-api-comparison/blob/0459e5dd51fa38df8bf24363f4fa5895ac5c2929/signatures/linalg/cholesky.md TL;DR: the kwarg was not universally supported. Among array libraries, PyTorch had |
This PR
Notes
NumPy (along with CuPy, JAX, MXNet, TF) does not allow returning either the lower- or upper-triangular Cholesky factor. However, SciPy, Torch, and Dask do support returning either. The ability to return either factor is common outside of the PyData ecosystem (MATLAB, LAPACK). Accordingly, the decision was made to include an
upperkeyword to support returning the upper-triangular Cholesky factor.Following Torch, MXNet, TF, NumPy, and JAX, this proposal allows for providing a stack of square matrices.