Skip to content

Move linear algebra APIs to an extension - #182

Merged
rgommers merged 3 commits into
mainfrom
linalg-cleanup
May 20, 2021
Merged

Move linear algebra APIs to an extension#182
rgommers merged 3 commits into
mainfrom
linalg-cleanup

Conversation

@kgryte

Copy link
Copy Markdown
Contributor

This PR

  • builds on gh-165 whereby only a small subset of linear algebra APIs are present in the top-level namespace and the rest are specified in a dedicated linalg sub-namespace as an extension to the array API standard.

Notes

  • How extensions should be authored and consumed remains to be decided. This PR should lay the groundwork for further specification.

@kgryte
kgryte requested a review from rgommersMay 16, 2021 03:16
@asmeurer

Copy link
Copy Markdown
Member

Did we decide to mirror the functions in the top-level namespace?

@rgommers

Copy link
Copy Markdown
Member

Did we decide to mirror the functions in the top-level namespace?

I believe that was indeed the preferred option. Discussion at #149 (review) followed by a discussion in the May 6th call where people seemed happy with @kgryte's proposal as implemented in this PR.

For others, it may help to capture how the PR in its current state is rendered. The API specification for the main namespace has these functions:

image

Extensions is a separate section:

image

And that section has all linear algebra functions in it (including the 5 in the main namespace, which are aliased).

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte

@rgommersrgommers added the Narrative Content Narrative documentation content. label May 16, 2021
@rgommers

Copy link
Copy Markdown
Member

Let me merge this, since people are busy implementing this in at least PyTorch. If there are more comments, let's deal with those in a follow-up PR.

@rgommers
rgommers merged commit 03a2b41 into mainMay 20, 2021
@rgommers
rgommers deleted the linalg-cleanup branch May 20, 2021 12:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Narrative ContentNarrative documentation content.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kgryte@asmeurer@rgommers