Skip to content

Clarify expected behavior when providing a complex number array to nonzero - #441

Merged
kgryte merged 1 commit into
mainfrom
cmplx-nonzero
Jun 6, 2022
Merged

Clarify expected behavior when providing a complex number array to nonzero#441
kgryte merged 1 commit into
mainfrom
cmplx-nonzero

Conversation

@kgryte

@kgrytekgryte commented May 23, 2022

Copy link
Copy Markdown
Contributor

This PR

  • clarifies expected behavior when providing a complex number array to nonzero. Namely, nonzero elements are those elements have either a real or imaginary component (or both) which is non-zero.
  • adds a note clarifying that, for boolean arrays, True is non-zero.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels May 23, 2022
@kgrytekgryte added this to the v2022 milestone May 23, 2022
@kgrytekgryte mentioned this pull request May 23, 2022
Closed
rgommers
rgommers approved these changes May 23, 2022
View reviewed changes

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte

kgryte commented Jun 6, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks, @leofang! As this PR now has two approvals and the changes are straightforward, will merge...

@kgryte
kgryte merged commit 41b1b39 into mainJun 6, 2022
@kgryte
kgryte deleted the cmplx-nonzero branch June 6, 2022 20:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommersrgommersrgommers approved these changes
@leofangleofangleofang approved these changes

Assignees

No one assigned

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.

Projects

None yet

Milestone

v2022

Development

Successfully merging this pull request may close these issues.

3 participants

@kgryte@rgommers@leofang