Uh oh!
There was an error while loading. Please reload this page.
Include __array_api_version__ in API specification section - #480
Merged
Conversation
6 tasks
After this is merged, let's also add a test to the conformance suite. |
This was referenced Sep 29, 2022
leofang
reviewed
Oct 5, 2022
Uh oh!
There was an error while loading. Please reload this page.
honnoforce-pushed
the
dunder-version-namespace-attr
branch
from
October 6, 2022 11:43
624c403 to
1b0491bCompareleofang
approved these changes
Oct 17, 2022
oleksandr-pavlyk
approved these changes
Oct 17, 2022
leofang
commented
Oct 17, 2022
Contributor
Merging as this got two green checks and is what we should have had. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xp.__array_api_version__has been specified in our Versioning section for a while now (~2yrs), but no such mention of it is found in the API specification section, which is probably why this wasn't implemented in numpy/numpy/pull/18585 and all subsequent adoption efforts across the ecosystem (happy to submit respective PRs after we get this in).So this PR simply creates a
spec/API_specification/version.rstfile which includes a documented__array_api_version__attribute, which also will show up in ourarray-api/latest/API_specification/page (as well as the sidebar).