Uh oh!
There was an error while loading. Please reload this page.
Update type promotion rules for complex dtypes - #491
Conversation
- Add a table with promotion rules - Update type promotion lattice diagram Closesdata-apisgh-477Closesdata-apisgh-478
kgryte
commented
Nov 3, 2022
Based on discussions on gh-478 and during the 22 September 2022 consortium meeting, we should update this PR to have a single floating-point table with both real and complex floating-point data types, as proposed by Leo (see #478 (comment)). TensorFlow's lack of real-complex dtype promotion was not considered a blocker. An increase in the number of kernels (i.e., implementations for specific dtype pairs) was also not considered a blocker. The number of kernels an array library chooses to implement is an implementation detail; from a user POV, the expectation is that mixed real-complex promotion should just work. |
rgommers
commented
Nov 16, 2022
Okay, this should be good to go now (please squash commits when merging). Apologies for the delay. |
Closesgh-477
Closesgh-478
On gh-478, @leofang made a different suggestion regarding the actual rules (mixed-kind real/complex allowed), so let's discuss that there before merging this. Marking as draft for now.